Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add servicebus-dotnet-functionapp template #166

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

Gordonby
Copy link

@Gordonby Gordonby commented Jun 27, 2023

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:
    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!

Closes #122

@hemarina
Copy link
Contributor

@v-xuto Would you test this template when you get a chance?
@jongio Would you take a review on this template?

@v-xuto
Copy link
Member

v-xuto commented Jul 25, 2023

@v-xuto Would you test this template when you get a chance?

Sure. We will start testing this template today.

@v-xuto
Copy link
Member

v-xuto commented Jul 26, 2023

@hemarina We have completed the testing of this template without any issues.

@jongio
Copy link
Member

jongio commented Jul 27, 2023

LGTM

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemarina hemarina merged commit 470afe4 into Azure:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New azd-template] servicebus-dotnet-functionapp
4 participants