Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): docusaurus template in aca using msi #167

Merged
merged 13 commits into from
Aug 7, 2023

Conversation

jsburckhardt
Copy link
Contributor

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

  • [] Name of resource
  • [] Resource author - who created this resource? (so we can credit them!)
  • [] What section should this resource be included in? -Is the resource an article? A video? Something else?

@jsburckhardt
Copy link
Contributor Author

jsburckhardt commented Jul 14, 2023

@jsburckhardt
Copy link
Contributor Author

Hi folks, am I missing something for the PR? Cheers

@hemarina
Copy link
Contributor

@jsburckhardt Thank you for your contribution.
@v-xuto Would you test this template?

@v-xuto
Copy link
Member

v-xuto commented Jul 25, 2023

@v-xuto Would you test this template?

Sure. We will start testing this template today.

@jsburckhardt
Copy link
Contributor Author

jsburckhardt commented Jul 26, 2023

Sure

Btw, if you have any questions or trouble please reach out. We are using the template already in a demo, so happy to help :)

@v-xuto
Copy link
Member

v-xuto commented Jul 28, 2023

@hemarina We have finished the template test, and we filed two issues. Please review.

@jsburckhardt
Copy link
Contributor Author

@hemarina We have finished the template test, and we filed two issues. Please review.

Hi @v-xuto, thanks for the issues! fixed and merged. Here is the link

@v-xuto
Copy link
Member

v-xuto commented Jul 28, 2023

Hi @v-xuto, thanks for the issues! fixed and merged. Here is the link

@jsburckhardt LGTM

@v-xuto
Copy link
Member

v-xuto commented Jul 28, 2023

@hemarina Two issues have been fixed, currently this template has no issues.

@hemarina hemarina requested a review from jongio July 28, 2023 21:09
@hemarina
Copy link
Contributor

Sounds good. Would you mind taking a look for review approval @jongio?

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jongio will do a further check on the repro and bicep files.

@jsburckhardt
Copy link
Contributor Author

jsburckhardt commented Aug 2, 2023

hi @hemarina , I think the contribution flow is changing right? All I have to do is add the topic azd-templates to my repository? and relocate the files under static/templates, can you confirm. Cheers

@savannahostrowski savannahostrowski removed their request for review August 3, 2023 17:36
@hemarina hemarina merged commit e054531 into Azure:main Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants