-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): docusaurus template in aca using msi #167
Conversation
…emplate feat(template): docusaurus template in aca using msi
Hi folks, am I missing something for the PR? Cheers |
@jsburckhardt Thank you for your contribution. |
Sure. We will start testing this template today. |
Btw, if you have any questions or trouble please reach out. We are using the template already in a demo, so happy to help :) |
@hemarina We have finished the template test, and we filed two issues. Please review. |
@jsburckhardt LGTM |
@hemarina Two issues have been fixed, currently this template has no issues. |
Sounds good. Would you mind taking a look for review approval @jongio? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @jongio will do a further check on the repro and bicep files.
hi @hemarina , I think the contribution flow is changing right? All I have to do is add the topic |
Co-authored-by: hemarina <[email protected]>
Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new
azd
template to the galleryFill this out if you want your template to be added to the awesome-azd gallery!
Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:
website/src/data/images/
.In the PR comment, if you can also add a link to the PR where you made your repo
azd
compatible this will allow us to provide feedback on your template and speed up the review process.If you are submitting a resource to be added to the awesome-azd README: