Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlit #174

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Streamlit #174

merged 5 commits into from
Aug 7, 2023

Conversation

MiguelElGallo
Copy link
Contributor

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • [X ] Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

  • [] Name of resource
  • [] Resource author - who created this resource? (so we can credit them!)
  • [] What section should this resource be included in? -Is the resource an article? A video? Something else?

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiguelElGallo Thank you very much for your contribution. Just having some minor change requests.

website/src/data/users.tsx Outdated Show resolved Hide resolved
website/src/data/users.tsx Outdated Show resolved Hide resolved
website/src/data/tags.tsx Show resolved Hide resolved
@hemarina
Copy link
Contributor

@v-xuto Would you mind testing this template?
@jongio Would you mind reviewing and approving this template?

@v-xuto
Copy link
Member

v-xuto commented Aug 1, 2023

@v-xuto Would you mind testing this template?

Sure. We will start testing this template today.

@Menghua1
Copy link
Member

Menghua1 commented Aug 2, 2023

@hemarina, @MiguelElGallo We have finished this template test, and we found two issues. Please help review and fix. The following are the two issues:

  • Issue1. The applciation in the picture below is misspelled, please update to application.
    image

  • Issue2. There is no app.py file in this template, please update to stlitapp.py.
    image

@MiguelElGallo
Copy link
Contributor Author

MiguelElGallo commented Aug 2, 2023

@hemarina, @MiguelElGallo We have finished this template test, and we found two issues. Please help review and fix. The following are the two issues:

  • Issue1. The applciation in the picture below is misspelled, please update to application.
    image
  • Issue2. There is no app.py file in this template, please update to stlitapp.py.
    image

Hello,
Both issues have been fixed. Thanks for letting me know @Menghua1 ping @hemarina .
:)

@v-xuto
Copy link
Member

v-xuto commented Aug 3, 2023

@MiguelElGallo Regarding the fixes for these two issues, LGTM.

@hemarina We have completed the testing of this template without any issues.

@MiguelElGallo
Copy link
Contributor Author

Great! When can we expect the merge?

@savannahostrowski savannahostrowski removed their request for review August 3, 2023 17:36
@hemarina
Copy link
Contributor

hemarina commented Aug 3, 2023

Great! When can we expect the merge?

We are checking the repro and bicep files. Will get back to you next week.

@hemarina hemarina merged commit 0ae39b9 into Azure:main Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants