Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ais-apim-odata-reactjs template #185

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

pascalvanderheiden
Copy link
Contributor

@pascalvanderheiden pascalvanderheiden commented Aug 16, 2023

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:
https://github.com/pascalvanderheiden/ais-apim-odata-reactjs

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.
    [PH] Refactored here: pascalvanderheiden/ais-apim-odata-reactjs@9190409

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@hemarina
Copy link
Contributor

@v-xuto Would you mind testing this template?

@v-xuto
Copy link
Member

v-xuto commented Aug 21, 2023

@v-xuto Would you mind testing this template?

Sure. We will start testing this template today.

@v-xuto
Copy link
Member

v-xuto commented Aug 25, 2023

@hemarina, @pascalvanderheiden We have finished this template test, and we found one small issue. Please help review and fix.

  • The subcription in the picture below is misspelled, please update to subscription.
    image

@pascalvanderheiden
Copy link
Contributor Author

@hemarina, @pascalvanderheiden We have finished this template test, and we found one small issue. Please help review and fix.

  • The subcription in the picture below is misspelled, please update to subscription.
    image

Updated the readme.

@v-xuto
Copy link
Member

v-xuto commented Aug 28, 2023

@hemarina We have completed the testing of this template without any issues.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @jongio in case if there's any suggestions.

@hemarina hemarina changed the title Request to add ais-apim-odata-reactjs add ais-apim-odata-reactjs template Aug 28, 2023
@gkulin gkulin merged commit 0e3ecc3 into Azure:main Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants