Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bicep & terraform starter templates #195

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Sep 26, 2023

Adds bicep & terraform starter templates into Awesome AZD
Fixes Azure/azure-dev#2794

Copy link
Contributor

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @gkulin for input as well

@vhvb1989
Copy link
Member

Note: There should be a version that azd points to. It does not feel right to use the latest main as it is vulnerable to regressions

@wbreza
Copy link
Contributor Author

wbreza commented Sep 26, 2023

Note: There should be a version that azd points to. It does not feel right to use the latest main as it is vulnerable to regressions

The awesome-azd template source uses an aks.ms link https://aka.ms/awesome-azd/templates.json. Right now this points to main branch in awesome-azd repo. Main should be treated as last known good.

@vhvb1989
Copy link
Member

Note: There should be a version that azd points to. It does not feel right to use the latest main as it is vulnerable to regressions

The awesome-azd template source uses an aks.ms link https://aka.ms/awesome-azd/templates.json. Right now this points to main branch in awesome-azd repo. Main should be treated as last known good.

Yeah, that's what I see as an anti-pattern there.
There should be one aks.ms that point to latest (or daily) which folks can register to receive updated immediately.
And there should be one aks.ms for each repo-release. This helps to freeze the list of templates and avoid unexpected changes

@wbreza wbreza merged commit 09292c7 into Azure:main Sep 27, 2023
2 checks passed
@wbreza wbreza deleted the starter-templates branch September 27, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] When running azd init the Starter - Bicep template is not available.
4 participants