Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding llama index python template #414

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

marlenezw
Copy link
Contributor

@marlenezw marlenezw commented Jul 10, 2024

Your template repository

llama-index-python sample

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

@marlenezw
Copy link
Contributor Author

PR with azd support: https://github.com/Azure-Samples/llama-index-python/tree/main

@hemarina
Copy link
Contributor

@v-xuto Could you test this template?

@v-xuto
Copy link
Member

v-xuto commented Jul 12, 2024

@v-xuto Could you test this template?

Got it. Testing.

@kristenwomack kristenwomack self-requested a review July 16, 2024 14:39
@kristenwomack
Copy link
Contributor

@marlenezw - I've deployed the template, and everything is working well (thank you for all the fixes Friday/yesterday with Poetry, etc). I still have to do pipeline config. Great validation steps in your README. I'll retest after you have a chance to look at the issues @v-xuto logged.

@marlenezw
Copy link
Contributor Author

Hi @kristenwomack and @v-xuto, I've updated the code and closed all the issues mentioned in the repo. Please have a look.
Thanks

Copy link
Contributor

@kristenwomack kristenwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm up and running and the template instructions are smooth. Thank you @marlenezw

@hemarina hemarina merged commit 6eb3ff5 into Azure:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants