Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello azd template #440

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

alexwolfmsft
Copy link
Contributor

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

https://github.com/Azure-Samples/hello-azd

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@hemarina
Copy link
Contributor

@v-xuto Could you test this template please?

@v-xuto
Copy link
Member

v-xuto commented Sep 23, 2024

@v-xuto Could you test this template please?

@hemarina, @hemarina We have finished this template test, and we filed one issue. Please review.

@alexwolfmsft
Copy link
Contributor Author

@v-xuto The error in your run appears to be caused by the devcontainer file, which didn't include a line to install the .NET SDK. I've updated this file and tested it - it worked for me in codespaces, can you re-test this? Thanks!

@v-xuto
Copy link
Member

v-xuto commented Sep 24, 2024

@v-xuto The error in your run appears to be caused by the devcontainer file, which didn't include a line to install the .NET SDK. I've updated this file and tested it - it worked for me in codespaces, can you re-test this? Thanks!

@alexwolfmsft We have tested it, this issue has been fixed.

@hemarina The issue has been fixed. There are currently on issues with this template. Please review.

@alexwolfmsft
Copy link
Contributor Author

Hey @hemarina just let me know if there is anything else I can do to help with this, thanks!

@alexwolfmsft
Copy link
Contributor Author

@hemarina are you able to take another look at this?

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexwolfmsft LGTM. Thank you for your contributions and patience. I was OOF last week.

website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
@hemarina hemarina merged commit 53f0994 into Azure:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants