Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic App Standard and Consumption templates #455

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

marnixcox
Copy link
Contributor

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:

https://github.com/marnixcox/integration-hub
https://github.com/marnixcox/logicapp-standard-func
https://github.com/marnixcox/logicapp-consumption

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@marnixcox
Copy link
Contributor Author

marnixcox commented Oct 22, 2024

@microsoft-github-policy-service agree

@hemarina
Copy link
Contributor

@v-xuto Could you test these templates?

@v-xuto
Copy link
Member

v-xuto commented Oct 25, 2024

@v-xuto Could you test these templates?

@hemarina, @marnixcox We have finished this template test, and we filed three issues. Please review.

@marnixcox
Copy link
Contributor Author

@v-xuto Many thanks for your assistance. Think I have updated/corrected them all now.

@v-xuto
Copy link
Member

v-xuto commented Oct 28, 2024

@v-xuto Many thanks for your assistance. Think I have updated/corrected them all now.

@marnixcox We have retested these issues, the following are their latest status:

In addition, during the retesting process, a new issue was found due to the update of the readme, please review.

@v-xuto
Copy link
Member

v-xuto commented Oct 29, 2024

@hemarina All issues have been fixed. There are currently no issues with this template. Please review.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions!

@hemarina hemarina merged commit 3f2a54d into Azure:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants