Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
bragi92 committed Aug 5, 2024
1 parent a144e7a commit 656ab30
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/aks-preview/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++
* az aks create/update: Support in place param updates for managed prom

7.0.0b2
++++++++
Expand Down
1 change: 1 addition & 0 deletions src/aks-preview/azext_aks_preview/addonconfiguration.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ def update_addons(

def add_ingress_appgw_addon_role_assignment(result, cmd):
service_principal_msi_id = None
is_service_principal = False
# Check if service principal exists, if it does, assign permissions to service principal
# Else, provide permissions to MSI
if (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def ensure_azure_monitor_profile_prerequisites(
# Do RP registrations and artifact creation (DC*, rules, grafana link etc.) if not enabled already
# Otherwise move forward so that the addon can be enabled with new KSM parameters
if is_prometheus_enabled is False:
rp_registrations(cmd, cluster_subscription, raw_parameters)
rp_registrations(cmd, cluster_subscription)
link_azure_monitor_profile_artifacts(
cmd,
cluster_subscription,
Expand Down

0 comments on commit 656ab30

Please sign in to comment.