Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision suffix validation logic prevents suffixes that start with number #6449

Closed
ruslany opened this issue Jun 27, 2023 · 4 comments
Closed
Assignees
Labels
Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. ContainerApp CXP Attention This issue is handled by CXP team.

Comments

@ruslany
Copy link
Contributor

ruslany commented Jun 27, 2023

Describe the bug

Use the following command to create a new containerapp or a revision on existing app. Make sure that the revision-suffix starts with a number.

export BLUE_COMMIT_ID=0b699ef
az containerapp create --name $APP_NAME
--environment $APP_ENVIRONMENT_NAME
--resource-group $RESOURCE_GROUP
--image mcr.microsoft.com/k8se/samples/test-app:$BLUE_COMMIT_ID
--revision-suffix $BLUE_COMMIT_ID
--env-vars REVISION_COMMIT_ID=$BLUE_COMMIT_ID
--ingress external
--target-port 80
--revisions-mode multiple

This results in a validation error

Related command

az containerapp create

Errors

Invalid Container App revision name '{value}'. A revision name must consist of lower case alphanumeric characters or '-', start with a letter, end with an alphanumeric character and cannot have '--'.

Issue script & Debug output

N/A

Expected behavior

The command should allow revision suffix that starts with a number

Environment Summary

Latest version

Additional context

No response

@ruslany ruslany added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jun 27, 2023
@ghost ghost added Auto-Assign Auto assign by bot ContainerApp CXP Attention This issue is handled by CXP team. labels Jun 27, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 27, 2023

Thank you for opening this issue, we will look into it.

@ruslany ruslany changed the title Refi Revision suffix validation logic prevents suffixes that start with number Jun 27, 2023
@ruslany
Copy link
Contributor Author

ruslany commented Jun 27, 2023

PR: #6448

@navba-MSFT
Copy link
Contributor

@ruslany Thanks for reaching out to us and reporting this issue. Since you have filed the PR already which includes the fix. I am assigning this issue to you.

@PramodValavala-MSFT
Copy link
Contributor

@ruslany This PR has been merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. ContainerApp CXP Attention This issue is handled by CXP team.
Projects
None yet
Development

No branches or pull requests

4 participants