Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the revision suffix validation bug #6448

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

ruslany
Copy link
Contributor

@ruslany ruslany commented Jun 27, 2023


Description

Fix the revision suffix validation bug for az containerapp create command. The bug prevented using revision suffixes that started with numbers.

Related command

export BLUE_COMMIT_ID=0b699ef
az containerapp create --name $APP_NAME
--environment $APP_ENVIRONMENT_NAME
--resource-group $RESOURCE_GROUP
--image mcr.microsoft.com/k8se/samples/test-app:$BLUE_COMMIT_ID
--revision-suffix $BLUE_COMMIT_ID
--env-vars REVISION_COMMIT_ID=$BLUE_COMMIT_ID
--ingress external
--target-port 80
--revisions-mode multiple

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @ruslany,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @ruslany,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost requested a review from yonzhan June 27, 2023 21:53
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 27, 2023
@ghost ghost requested a review from wangzelin007 June 27, 2023 21:54
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 27, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd June 27, 2023 21:54
@ghost ghost assigned zhoxing-ms Jun 27, 2023
@ghost ghost added the ContainerApp label Jun 27, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy June 27, 2023 21:54
@ruslany
Copy link
Contributor Author

ruslany commented Jun 27, 2023

Hi @ruslany, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

fixed.

@ruslany
Copy link
Contributor Author

ruslany commented Jun 27, 2023

Issue #6449

@zhoxing-ms
Copy link
Contributor

@ruslany Please take a look at this comment #6448 (comment)

@ruslany
Copy link
Contributor Author

ruslany commented Jun 29, 2023

@ruslany Please take a look at this comment #6448 (comment)

@zhoxing-ms - thanks! Updated.

@zhoxing-ms zhoxing-ms merged commit 0aaccb0 into Azure:main Jun 30, 2023
13 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=68409&view=results

@ruslany ruslany deleted the fixrevisionvalidation branch June 30, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants