-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the revision suffix validation bug #6448
Conversation
Hi @ruslany, |
Hi @ruslany, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
fixed. |
Issue #6449 |
@ruslany Please take a look at this comment #6448 (comment) |
@zhoxing-ms - thanks! Updated. |
…revisionvalidation
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=68409&view=results |
Description
Fix the revision suffix validation bug for az containerapp create command. The bug prevented using revision suffixes that started with numbers.
Related command
export BLUE_COMMIT_ID=0b699ef
az containerapp create --name $APP_NAME
--environment $APP_ENVIRONMENT_NAME
--resource-group $RESOURCE_GROUP
--image mcr.microsoft.com/k8se/samples/test-app:$BLUE_COMMIT_ID
--revision-suffix $BLUE_COMMIT_ID
--env-vars REVISION_COMMIT_ID=$BLUE_COMMIT_ID
--ingress external
--target-port 80
--revisions-mode multiple
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.