Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI command for binding a service to a container app #6083

Merged
merged 1 commit into from
May 17, 2023
Merged

Add CLI command for binding a service to a container app #6083

merged 1 commit into from
May 17, 2023

Conversation

yash-nisar
Copy link
Contributor

Add CLI command for binding a service to an app

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @yash-nisar,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost requested a review from yonzhan March 29, 2023 01:41
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 29, 2023
@ghost ghost requested review from wangzelin007 and yanzhudd March 29, 2023 01:41
@ghost ghost assigned zhoxing-ms Mar 29, 2023
@ghost ghost added the ContainerApp label Mar 29, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy March 29, 2023 01:42
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2023

container app

@yash-nisar yash-nisar changed the title Add CLI command for binding a service to a container app [WIP] Add CLI command for binding a service to a container app Mar 30, 2023
@yash-nisar yash-nisar force-pushed the bindings_cli branch 2 times, most recently from 219612e to 9df2306 Compare March 30, 2023 23:50
@yash-nisar yash-nisar changed the title [WIP] Add CLI command for binding a service to a container app Add CLI command for binding a service to a container app Mar 31, 2023
@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Mar 31, 2023 •
edited
Loading

Could you please resolve these conflicts?

@zhoxing-ms
Copy link
Contributor

Please add the description of PR change into the HISTORY.rst. If you want to release a new extension for this PR, please also upgrade the version defined in the setup.py.

@yash-nisar yash-nisar changed the title Add CLI command for binding a service to a container app [WIP] Add CLI command for binding a service to a container app Apr 5, 2023
@yash-nisar yash-nisar force-pushed the bindings_cli branch 5 times, most recently from d39fb9f to 1476d28 Compare May 15, 2023 23:06
@yash-nisar yash-nisar force-pushed the bindings_cli branch 3 times, most recently from 2a4e274 to 4cd2ac2 Compare May 16, 2023 00:38
@yash-nisar yash-nisar force-pushed the bindings_cli branch 3 times, most recently from db136ce to 625e919 Compare May 16, 2023 02:45
@yash-nisar yash-nisar changed the title [WIP] Add CLI command for binding a service to a container app Add CLI command for binding a service to a container app May 16, 2023
@yash-nisar
Copy link
Contributor Author

Can I get a review on this ?

@yash-nisar
Copy link
Contributor Author

Managed service tests are taking forever to run, essentially because of provisioning them first via the cli, have been trying them all day

@yash-nisar
Copy link
Contributor Author

yash-nisar commented May 16, 2023 •
edited
Loading

The idea for running managed service tests is to provision them via the az cli and then use the service connector/linker commands to get a json output. Just provisioning the managed redis cache took me a lot of time so not sure if we want to include them to tremendously increase the test suite time. I waited a whole 10 mins and still didn't receive a successful operation.

image

@yash-nisar yash-nisar force-pushed the bindings_cli branch 2 times, most recently from a1adb46 to 57230bd Compare May 16, 2023 22:58
@zhoxing-ms zhoxing-ms merged commit 8fa8622 into Azure:main May 17, 2023
Greedygre
Greedygre reviewed May 17, 2023
View reviewed changes
src/containerapp/azext_containerapp/commands.py

with self.command_group('containerapp service postgres') as g:
g.custom_command('create', 'create_postgres_service', supports_no_wait=True)
g.custom_command('delete', 'delete_postgres_service', confirmation=True, supports_no_wait=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'az containerapp service postgres delete' and 'az containerapp service redis delete' is new commands, need tests cover.

Copy link
Contributor Author

@yash-nisar yash-nisar May 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a new issue to track this: #6302. Can you assign it to me ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@yash-nisar yash-nisar deleted the bindings_cli branch May 18, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Greedygre Greedygre Greedygre approved these changes

@Juliehzl Juliehzl Juliehzl left review comments

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@jsntcy jsntcy Awaiting requested review from jsntcy

Assignees

@zhoxing-ms zhoxing-ms

Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Milestone
May 2023 (2023-05-23) - For Build
Development

Successfully merging this pull request may close these issues.
5 participants
@yash-nisar @yonzhan @zhoxing-ms @Greedygre @Juliehzl