Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pbouchon/wlp bugs #6243

Merged
merged 9 commits into from
May 16, 2023
Merged

Pbouchon/wlp bugs #6243

merged 9 commits into from
May 16, 2023

Conversation

p-bouchon
Copy link
Contributor

@p-bouchon p-bouchon commented Apr 28, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 28, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 5, 2023

Please add deprecate_info=c.deprecate(hide=True) flag for the deprecated command containerapp env workload-profile set. For more details, please refer to this doc deprecating-commands-and-arguments

@@ -4,6 +4,10 @@ Release History
===============
Upcoming
++++++
* Remove 'az containerapp env workload-profile set' split into 'az containerapp env workload-profile add' and 'az containerapp env workload-profile update'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Remove 'az containerapp env workload-profile set' split into 'az containerapp env workload-profile add' and 'az containerapp env workload-profile update'
* Split 'az containerapp env workload-profile set' into 'az containerapp env workload-profile add' and 'az containerapp env workload-profile update'

@zhoxing-ms zhoxing-ms merged commit 32208ea into Azure:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants