[vm-repair] Adding repair-and-restore one command flow for fstab scripts #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-client-tools-bot-prd
bot
added this to the May 2023 (2023-05-23) - For Build milestone
|
vm-repair |
yonzhan
modified the milestones:
May 2023 (2023-05-23) - For Build,
June 2023 (2023-07-04)
yanzhudd
reviewed
Jun 14, 2023
| examples: | ||
| - name: Repair and restore a VM. | ||
| text: > | ||
| az vm repair repair-and-restore --name "vmrepairtest" --resource-group "MyResourceGroup" --verbose |
There was a problem hiding this comment.
Suggested change
| az vm repair repair-and-restore --name "vmrepairtest" --resource-group "MyResourceGroup" --verbose | |
| az vm repair repair-and-restore --name vmrepairtest --resource-group MyResourceGroup --verbose |
yanzhudd
reviewed
Jun 14, 2023
Comment on lines
426
to
429
| namespace.repair_username = "azureuser" | ||
| validate_vm_username(namespace.repair_username, is_linux) | ||
| namespace.repair_password = "!AzureUser@123" | ||
| validate_vm_password(namespace.repair_password, is_linux) |
There was a problem hiding this comment.
May I ask if this operation tries to set the default values of repair_username and repair_password?
Suggested change
| namespace.repair_username = "azureuser" | |
| validate_vm_username(namespace.repair_username, is_linux) | |
| namespace.repair_password = "!AzureUser@123" | |
| validate_vm_password(namespace.repair_password, is_linux) | |
| if not namespace.repair_username: | |
| namespace.repair_username = "azureuser" | |
| validate_vm_username(namespace.repair_username, is_linux) | |
| if not namespace.repair_password: | |
| namespace.repair_password = "!AzureUser@123" | |
| validate_vm_password(namespace.repair_password, is_linux) |
There was a problem hiding this comment.
Thanks for suggesting but I fixed this to remove the default values.
yanzhudd
reviewed
Jun 14, 2023
| return urns[0] | ||
|
|
||
|
|
||
| def _suse_image_selector_gen2(distro): | ||
| fetch_urn_command = 'az vm image list --publisher SUSE --offer {offer} --sku gen2 --verbose --all --query "[].urn | reverse(sort(@))" -o json'.format(offer=distro) | ||
| logger.info('Fetching compatible SUSE OS images from gallery...') | ||
| # logger.info('Fetching compatible SUSE OS images from gallery...') |
There was a problem hiding this comment.
It is recommended to remove deprecated code instead of commenting them.
|
Please add test for the new feature and fix the CI. |
Co-authored-by: Yan Zhu <[email protected]>
…e-cli-extensions into haagha/repairrestore
|
@yanzhudd Thanks for reviewing. I made the changes suggested. |
yanzhudd
reviewed
Jun 27, 2023
yanzhudd
reviewed
Jun 27, 2023
yanzhudd
reviewed
Jun 27, 2023
yanzhudd
reviewed
Jun 27, 2023
yanzhudd
approved these changes
Jun 27, 2023
|
[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=67280&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.