Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{dataprotection} quickfix: making the aaz_operations folder a module #6372

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

zubairabid
Copy link
Contributor


Quickfix for issue that broke CI for Azure Help.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @zubairabid,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested a review from yonzhan June 6, 2023 12:11
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 6, 2023
@ghost ghost requested a review from evelyn-ys June 6, 2023 12:11
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 6, 2023

dataprotection

@ghost ghost assigned evelyn-ys Jun 6, 2023
@ghost ghost added the Data Protection label Jun 6, 2023
@ghost ghost requested a review from calvinhzy June 6, 2023 12:11
Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to release a new version? If so, don't forget to upgrade version in setup.py and history.rst

@zubairabid
Copy link
Contributor Author

Do you need to release a new version? If so, don't forget to upgrade version in setup.py and history.rst

@evelyn-ys I've updated the files, to version 0.8.2

Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is the version here:

@zubairabid
Copy link
Contributor Author

What I mean is the version here:

Got it, I had made the change but staged/committed another file that wasn't changed. That has been updated now.

@evelyn-ys evelyn-ys merged commit d1f00eb into Azure:main Jun 7, 2023
@azclibot
Copy link
Collaborator

azclibot commented Jun 7, 2023

[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=60851&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants