Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Service Connector} fix compatibility issue and refactor #6376

Merged
merged 7 commits into from
Jun 12, 2023

Conversation

xfz11
Copy link
Member

@xfz11 xfz11 commented Jun 7, 2023

Refactor the firewall updates rule

  • First, get the local IP address from websites
    • If it succeeds, try to add the local ip address and connect
    • If it fails, try to ask user to input local ip address (added)
      • If user input a valid IP, add it to firewall. Else, keep asking for a valid IP
      • If user choose to add all ip address, add all IP range to firewall
      • If user have no TTY, throw exception and fail
  • If user local IP address is not working, prompt a confirmation to add all IP
    • If user approve, add all IP and retry to connect
    • If user reject, fail the command

@houk-ms the refactor detail. Add a fallback logic to ask for user input a local ip in the case IP can't got from 3rd party website.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @xfz11,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 7, 2023

Service Connector

Copy link
Contributor

@houk-ms houk-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some desciptions on what changes are made in this PR?

@kairu-ms kairu-ms merged commit 1ee7908 into Azure:main Jun 12, 2023
13 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ serviceconnector-passwordless ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=62555&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants