-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Service Connector} fix compatibility issue and refactor #6376
Conversation
Hi @xfz11, |
Service Connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give some desciptions on what changes are made in this PR?
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
Show resolved
Hide resolved
[Release] Update index.json for extension [ serviceconnector-passwordless ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=62555&view=results |
Refactor the firewall updates rule
@houk-ms the refactor detail. Add a fallback logic to ask for user input a local ip in the case IP can't got from 3rd party website.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.