{AKS} Update monitor metrics related option names #6379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
AKS |
ghost
assigned
FumingZhang
commented
Jun 8, 2023
| @@ -6431,7 +6431,7 @@ def test_aks_create_with_azuremonitormetrics(self, resource_group, resource_grou | |||
| }) | |||
|
|
|||
| create_cmd = 'aks create --resource-group={resource_group} --name={name} --location={location} --ssh-key-value={ssh_key_value} --node-vm-size={node_vm_size} ' \ | |||
| '--enable-managed-identity --enable-azuremonitormetrics --enable-windows-recording-rules --output=json' | |||
| '--enable-managed-identity --enable-azure-monitor-metrics --enable-windows-recording-rules --output=json' | |||
There was a problem hiding this comment.
Queued live test pipeline to validate the touched test cases. Test passed.
3 tasks
zhoxing-ms
approved these changes
Jun 11, 2023
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=62475&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Deprecate option names
--enable-azuremonitormetricsand--disable-azuremonitormetrics, use--enable-azure-monitor-metricsand--disable-azure-monitor-metricsinstead, so as to be consistent with the option names in official azure-cli. Fix issue #26600.Related command
az aks createaz aks updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.