Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix live test execution by fixing version of vcrpy #6390

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Fix the version of a lib vcrpy (used by testsdk) to 4.2.1 to fix live test execution. There're some compatibility issues between vcrpy>=4.3.0 and urllib3 (v1).

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested review from zhoxing-ms and yanzhudd June 12, 2023 02:29
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2023

AKS

@ghost ghost assigned zhoxing-ms Jun 12, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 12, 2023
@ghost ghost requested a review from yonzhan June 12, 2023 02:30
@ghost ghost added the AKS label Jun 12, 2023
@FumingZhang FumingZhang marked this pull request as ready for review June 12, 2023 02:54
@zhoxing-ms zhoxing-ms merged commit 7ec9e12 into Azure:main Jun 12, 2023
14 checks passed
@FumingZhang FumingZhang deleted the fuming/fix-aks-0610 branch June 28, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants