Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ManagedNetworkFabric 2023-02-01-preview API #6392

Merged
merged 13 commits into from
Jun 15, 2023

Conversation

rahulm-msft
Copy link
Contributor

@rahulm-msft rahulm-msft commented Jun 12, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az networkfabric -h

Group
    az networkfabric                : Manage Azure Network Fabric Management Service API.

Subgroups:
    acl                 : Manage Access Control List Resource.
    controller          : Manage Network Fabric Controller Resource.
    device              : Manage Network Device Resource.
    devicesku           : Manage Network Device SKU Resource.
    externalnetwork     : Manage External Network Resource.
    fabric              : Manage Network Fabric Resource.
    fabricsku           : Manage Network Fabric SKU Resource.
    interface           : Manage Network Interface Resource.
    internalnetwork     : Manage Internal Network Resource.
    ipcommunity         : Manage Ip Community Resource.
    ipextendedcommunity : Manage Ip Extended Community Resource.
    ipprefix            : Manage Ip Prefix Resource.
    l2domain            : Manage L2 Isolation Domain Resource.
    l3domain            : Manage L3 Isolation Domain Resource.
    nni                 : Manage Network To Network Interconnect Resource.
    rack                : Manage Network Rack Resource.
    racksku             : Manage Network Rack SKU Resource.
    routepolicy         : Manage Route Policy Resource.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @rahulm-msft,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@rahulm-msft
Copy link
Contributor Author

This PR has been updated with review comments addressed.

@kairu-ms
Copy link
Contributor

This PR has been updated with review comments addressed.

Added two more comments. The rest LGTM

@rahulm-msft
Copy link
Contributor Author

@kairu-ms This PR has been updated with above review comments addressed.

@kairu-ms kairu-ms merged commit 0a58800 into Azure:main Jun 15, 2023
13 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ managednetworkfabric ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=64749&view=results

@rahulm-msft rahulm-msft deleted the rahulm-msft/managedNetworkFabric branch August 1, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants