Add the network observability cli extension #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @snguyen64, |
ghost
requested review from
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ghost
added
the
snguyen64
force-pushed
the
feat/kappie-cli-extension
branch
3 times, most recently
from
2847e0b
to
d053d3b
Compare
snguyen64
force-pushed
the
feat/kappie-cli-extension
branch
from
2c3dc89
to
59018be
Compare
…er exclusion for flag char limit
snguyen64
force-pushed
the
feat/kappie-cli-extension
branch
from
59018be
to
33c5387
Compare
vakalapa
approved these changes
Jun 13, 2023
zhoxing-ms
approved these changes
Jun 14, 2023
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=64263&view=results |
FumingZhang
reviewed
Jun 14, 2023
| @@ -2370,6 +2377,12 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster: | |||
| else: | |||
| network_profile.network_dataplane = self.context.get_network_dataplane() | |||
|
|
|||
| network_observability = self.context.get_enable_network_observability() | |||
| if network_observability is not None: | |||
| network_profile.network_monitoring = self.models.NetworkMonitoring( | |||
There was a problem hiding this comment.
Queued a live test pipeline and the create test case failed.
Seems the property name used here is wrong. Should be network_profile.monitoring instead of network_profile.network_monitoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--enable-network-observabilityflag is used to enable network observability on an aks cluster. This adds the cli command to enable or disable this extension.Related command
az aks createaz aks updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.