Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{all services} Reorganized reference TOC by product or service (extensions) #6394

Merged
merged 16 commits into from
Jun 29, 2023

Conversation

dbradish-microsoft
Copy link
Contributor

@dbradish-microsoft dbradish-microsoft commented Jun 12, 2023

The purpose of this PR is to refresh our reference TOC in corrected product or service groups. Sister PR is Azure/azure-cli#26657

@azure-client-tools-bot-prd
Copy link

Hi @dbradish-microsoft,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@dbradish-microsoft dbradish-microsoft changed the title reorganized reference TOC by product or service TOC | reorganized reference TOC by product or service (extensions) Jun 12, 2023
@dbradish-microsoft dbradish-microsoft marked this pull request as ready for review June 20, 2023 15:45
@dbradish-microsoft
Copy link
Contributor Author

@dcaro , @jsntcy, I fixed build validation errors yesterday that are now popping up with time. If you could kindly review this PR and/or respond to conversations, I'd be grateful.

Copy link

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in different locations.

src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
@dbradish-microsoft dbradish-microsoft changed the title TOC | reorganized reference TOC by product or service (extensions) {all services} Reorganized reference TOC by product or service (extensions) Jun 26, 2023
@dbradish-microsoft
Copy link
Contributor Author

@jsntcy / @kairu-ms, @dcaro and I had a final review of this PR today. Can you please merge before more build conflicts pop up? Thank you.

#sign-off

@jsntcy
Copy link
Member

jsntcy commented Jun 27, 2023

@jsntcy / @kairu-ms, @dcaro and I had a final review of this PR today. Can you please merge before more build conflicts pop up? Thank you.

#sign-off

I still saw some comments from Damien were not resolved yet and also some suggestions were not committed yet.

@dbradish-microsoft
Copy link
Contributor Author

@jsntcy, thank you for finding those missed suggestions. Does everything look okay now?

Sister PR: Azure/azure-cli#26657

@jsntcy
Copy link
Member

jsntcy commented Jun 28, 2023

LGTM
@dcaro, do you have any other comments? If no, I'll merge this PR.

@dbradish-microsoft
Copy link
Contributor Author

@jsntcy, please merge in sync with Sister PR: Azure/azure-cli#26657. @dcaro and I are expecting a 2nd round of PRs with fewer edits once we see how the two Core and Extension files merged together.

@jsntcy jsntcy merged commit b8d4a3a into Azure:main Jun 29, 2023
@dcaro
Copy link

dcaro commented Jun 29, 2023

@jsntcy can we include the above changes in this release?

@jsntcy
Copy link
Member

jsntcy commented Jun 29, 2023

@jsntcy can we include the above changes in this release?

Yes, I created a PR for it, #6459, please help review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants