Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container app create not waiting for ready environment #6399

Merged
merged 6 commits into from
Jun 25, 2023

Conversation

p-bouchon
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @p-bouchon,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested a review from yonzhan June 13, 2023 15:39
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 13, 2023
@ghost ghost requested a review from wangzelin007 June 13, 2023 15:39
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 13, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd June 13, 2023 15:39
@ghost ghost assigned zhoxing-ms Jun 13, 2023
@ghost ghost added the ContainerApp label Jun 13, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy June 13, 2023 15:39
@zhoxing-ms
Copy link
Contributor

@p-bouchon Please take a look at this comment #6399 (comment) first.

@zhoxing-ms zhoxing-ms merged commit 0e70a46 into Azure:main Jun 25, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants