Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subPath and mountOptions for AzureContainerApps #6403

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

LaylaLiu-gmail
Copy link
Contributor

@LaylaLiu-gmail LaylaLiu-gmail commented Jun 14, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp create --yaml
az containerapp update --yaml

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @LaylaLiu-gmail,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost requested a review from yonzhan June 14, 2023 06:20
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 14, 2023
@ghost ghost requested a review from wangzelin007 June 14, 2023 06:20
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd June 14, 2023 06:20
@ghost ghost assigned zhoxing-ms Jun 14, 2023
@ghost ghost added the ContainerApp label Jun 14, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy June 14, 2023 06:20
@AllowLargeResponse(8192)
@ResourceGroupPreparer(location=TEST_LOCATION)
def test_container_app_mount_azurefile_e2e(self, resource_group):
env = self.create_random_name(prefix='env', length=24)
Copy link
Contributor

@Greedygre Greedygre Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add following code to support test run in different locations:
self.cmd('configure --defaults location={}'.format(TEST_LOCATION))

The @ResourceGroupPreparer(location=TEST_LOCATION) above can only create a resource group in the incoming location. But the resources created in test will not set --location as the location where the resource group is located.

@zhoxing-ms zhoxing-ms merged commit 5f3ec9b into Azure:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants