Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closed] ACS extension #6404

Closed
wants to merge 10 commits into from
Closed

Conversation

amritas
Copy link
Contributor

@amritas amritas commented Jun 14, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @amritas,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@amritas amritas changed the title Codesigning extension [Draft] Codesigning extension Jun 14, 2023
@amritas amritas changed the title [Draft] Codesigning extension [DoNotMerge] Codesigning extension Jun 14, 2023
@kairu-ms kairu-ms requested a review from AllyW June 14, 2023 07:06
@yonzhan yonzhan requested review from kairu-ms and jsntcy June 14, 2023 07:07
@kairu-ms kairu-ms removed their assignment Jun 14, 2023
# Azure CLI Codesigning Extension #
This is an extension to Azure CLI to manage Codesigning resources.

## How to use ##
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add code usage for users

is_experimental=True,
)
class Create(AAZCommand):
"""Create a Code Signing Account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for create/update cmd, please add code examples using codegen tool: add in corresponding cmd's workspace and then export.

is_experimental=True,
)
class Update(AAZCommand):
"""Update a Code Signing Account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for create/update cmd, please add code examples using codegen tool: add in corresponding cmd's workspace and then export.

is_experimental=True,
)
class Create(AAZCommand):
"""Create a certificate profile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for create/update cmd, please add code examples using codegen tool: add in corresponding cmd's workspace and then export.



class Update(AAZCommand):
"""Update a certificate profile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for create/update cmd, please add code examples using codegen tool: add in corresponding cmd's workspace and then export.



class CodesigningScenario(ScenarioTest):
# TODO: add tests here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests

@amritas amritas closed this Mar 8, 2024
@amritas amritas changed the title [DoNotMerge] Codesigning extension [Removed] ACS extension Mar 8, 2024
@amritas amritas changed the title [Removed] ACS extension [Closed] ACS extension Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants