Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oras target string #6409

Closed
wants to merge 127 commits into from
Closed

Fix oras target string #6409

wants to merge 127 commits into from

Conversation

Cyclam
Copy link
Contributor

@Cyclam Cyclam commented Jun 14, 2023

Small fix for broken ORAS target string.

Original error seen:

The command failed with an unexpected error. Here is the traceback:
HTTPSConnectionPool(host='ac4mitestingac4mitestingacred058481d7.azurecr.io%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20', port=443):

Those %20s are spaces that have crept in.

jddarby and others added 30 commits April 18, 2023 15:17
@jddarby
initial commit of azdev generated files and code
b0119b3
@jddarby
add SDK generated with autorest tool
b3d8ebc
@jddarby
Add missing file
af1accc
@jddarby
Commit changes
d4ee4e6
@sunnycarter
VNF NFD generator
cff0186
@sunnycarter
Merge pull request #1 from jddarby/sunny/vnf-definition
b761cac 
VNF NFD generator
@sunnycarter
Draft create NFDV using python SDK
5cdd0d8
@jddarby
Add deployer class
8cdf766
@sunnycarter
pushing this but then moving on to delete
105c809
@sunnycarter
Merge branch 'add-aosm-extension' into sunny/bicep-deployer
a2de28e
@sunnycarter
start to move to bicep deployer
9baaeb3
@sunnycarter
VNF generate and deploy bare bones, not working
4fa8b8a
@sunnycarter
predeployer maybe working
4ea921a
@sunnycarter
Fix up VNF generate and deploy
27a2597
@sunnycarter
printing
c19920e
@sunnycarter
artifact upload half broken
8bbe2b7
@sunnycarter
Artifact manifest stuff over to SDK
91cfe36
@sunnycarter
delete NFD function
a2410b4
@sunnycarter
linting
bfadbeb
@jddarby
add psudo code for CNF generation
1625852
@sunnycarter
Fix up json config -> VNFConfiguration
18d00d0
@jddarby
add psudo code for CNF generation
1b77c7e
@jddarby
Add CNFConfiguration
0d15355
Merge branch 'add-cnf-generation' of https://github.com/jddarby/azure…
fb0a3d3 
…-cli-extensions into add-cnf-generation
@sunnycarter
artifact manifests separate
bf0a29f
@sunnycarter
style
c741773
@sunnycarter
renames
a956ce6
@sunnycarter
style
7088b06
@sunnycarter
lint and reverse some renames
3e224a2
@sunnycarter
dev instructions
155c533
Jordan and others added 25 commits May 26, 2023 17:26
added location from input file not resourceGroup().location
d7f1b7a
@jordlay
Merge pull request #16 from jddarby/jl/manifest-location-bug
938b02e 
Fix wrong location creation bug
added path_to_mappings to input.json; added logic to take mappings fr…
ab95a7c 
…om file outside of helm package
renamed non_def_values to mappings_path
65ac401
@jordlay
Merge pull request #18 from jddarby/jl/change-value-mappings
371a1ea 
Move Value Mappings to Outside Helm Package
@patrykkulik-microsoft
Pk5/add nsd cli (#15)
dda5957 
* First working version of the CLI NSD create

* Fully working version of the NSD CLI

* minor change to nsd_generate

* Sunny's refactor

* First round of cleanup

* Secound Round of cleanup

* fix the 2023 api NSDV

* description updates

* deleted comment

* Fix SNS creation

* Fix SNS creation try 2

* markups

* delete unnecessary file

* Testing markups

* Fix the SNS attempt 3

* minor fixes

* Fix config validation
@jddarby
fix CNF depends on
cdfde0f
@jddarby
Merge pull request #19 from jddarby/jdd/fix-depends-on
25d05b1 
fix CNF depends on
@jddarby
Merge remote-tracking branch 'origin/main' into add-aosm-extension
6ed8ffa
initial commit; ran python static checks fmt (except on vendored sdks…
5b1e3aa 
…), fixed styling on _configuration.py
@Jamieparsons
Name uploaded VHD correctly
a1035f7
@Jamieparsons
Self review markups
77e2e95
fixed up configuration.py
b557b7f
fixed cnf generator styling
a7d7574
fixed styling for cnf generator
6d0520d
fixed up nfd generator base and deploy with arm
4c1a2ee
fixed styling for artifact.py
8e8db34
fixed styling for atrifact manifest .py
44299e6
@Jamieparsons
Code review markups
e38d425
@jamiedparsons
Merge pull request #20 from jddarby/JDP/bug-735056
6cda523 
Name uploaded VHD correctly
fixed more linting
d0f1276
fixed merge conflicts
a6c292c
@jordlay
Merge pull request #21 from jddarby/jl/fix-style
649ace6 
Jl/fix style
@sunnycarter
Sunny/choose deploy parameters (#23)
09be248 
* choose-deploy-parameters

* optioned deployParameters for CNF

* lint

* lint2

* docs

* docs

* lint

* 9.82 score

* Fix bugs

* more useful debug logs

* Fix bugs and logging

* lint

* markups
Fix for oras target string with erroneous spaces
e680931
@azure-client-tools-bot-prd
Copy link

Hi @Cyclam,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Cyclam Cyclam closed this Jun 14, 2023
@Cyclam Cyclam deleted the achurchard/fix_oras_target_string branch July 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
June 2023 (2023-07-04)
Development

Successfully merging this pull request may close these issues.
9 participants
@Cyclam @yonzhan @jddarby @sunnycarter @PerfectChaos @jordlay @patrykkulik-microsoft @Jamieparsons @jamiedparsons