-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managed MySQL Flexible server #6411
Conversation
Hi @yash-nisar, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
0baab94
to
a8804b1
Compare
Also could see env vars on curling the app:
Command to bind:
|
return {"linker_name": binding_name, "parameters": parameters, "resource_id": resource_id} | ||
|
||
|
||
class ManagedMySQLFlexibleUtils: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for command
az containerapp create/update --bind
to test the MySQL service binding.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test function added, thank you.
Could you please add some test case for this PR change? |
@bgashirabake is working on the tests and will continue this PR. Note: Since it takes ~6 mins to provision a flexible mysql server, the runtime of the test is expected to increase. |
️✔️Azure CLI Extensions Breaking Change Test
|
done. could you please take a look when you get the chance. thank you!! |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Show resolved
Hide resolved
…rapp_commands.py Co-authored-by: Xing Zhou <[email protected]>
Hi @zhoxing-ms @yanzhudd |
* Add support for managed MySQL Flexible server * fix * add change to history.rst * test add * fix duplicate env create cmd * test rerun * test update * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Co-authored-by: Xing Zhou <[email protected]> --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: Xing Zhou <[email protected]>
* Add support for managed MySQL Flexible server * fix * add change to history.rst * test add * fix duplicate env create cmd * test rerun * test update * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Co-authored-by: Xing Zhou <[email protected]> --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: Xing Zhou <[email protected]>
* Add support for managed MySQL Flexible server * fix * add change to history.rst * test add * fix duplicate env create cmd * test rerun * test update * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Co-authored-by: Xing Zhou <[email protected]> --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: bgashirabake <[email protected]> Co-authored-by: Xing Zhou <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.