-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring] Add addon configs & allowedOriginPatterns & restart for Spring Cloud Gateway #6412
Conversation
Hi @ninpan-ms, |
Spring |
Co-authored-by: Xing Zhou <[email protected]>
@@ -861,6 +861,10 @@ def prepare_logs_argument(c): | |||
help='Sensitive properties for environment variables. Once put, it will be encrypted and not returned.' | |||
'Format "key[=value]" and separated by space.') | |||
c.argument('allowed_origins', arg_group='Cross-origin Resource Sharing (CORS)', help="Comma-separated list of allowed origins to make cross-site requests. The special value `*` allows all domains.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, it is recommended to deprecate and hide the existing parameter --allowed-origins and replace it with a new parameter --allow-origins
It is recommended to keep the naming of parameter allowed_origins
consistent with parameter allowed_origin_patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As talked offline, we will keep the name consistent with other parameters first, which is referenced from VMware's product Spring Cloud Gateway. Later will consider to deprecate those parameters together.
[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=65347&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.