Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding managed identity subcommands and moving old identity commands to new subgroup #6427

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jorge-beauregard
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @jorge-beauregard,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Member

@mayssamm mayssamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The communication tests have not run (see under Checks, compare with a previous PR), I think because of the merge conflict that needs to be resolved first.

@@ -3,6 +3,10 @@
Release History
===============

1.5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have the latest in your main, latest is 1.6.0. Please sync your fork and update the PR. Also, for a change of this size, with all the auto generated code that runs behind the scenes updated, I would not recommend a minor version change. I would even recommend to bump the major version and going straight to 2 (2.0.0).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorge-beauregard, is this a breaking change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that all previous functionality still worked exactly the same way as it used to. Aside from all generated code being revamped, the interaction the final user has is still the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants