-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding managed identity subcommands and moving old identity commands to new subgroup #6427
base: main
Are you sure you want to change the base?
Conversation
Hi @jorge-beauregard, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The communication tests have not run (see under Checks, compare with a previous PR), I think because of the merge conflict that needs to be resolved first.
src/communication/HISTORY.rst
Outdated
@@ -3,6 +3,10 @@ | |||
Release History | |||
=============== | |||
|
|||
1.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you have the latest in your main, latest is 1.6.0. Please sync your fork and update the PR. Also, for a change of this size, with all the auto generated code that runs behind the scenes updated, I would not recommend a minor version change. I would even recommend to bump the major version and going straight to 2 (2.0.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorge-beauregard, is this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that all previous functionality still worked exactly the same way as it used to. Aside from all generated code being revamped, the interaction the final user has is still the same
9fb7485
to
4815ccd
Compare
8787244
to
c7e9bcf
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.