{AKS} Add support for option --aks-custom-headers to some aks commands
#6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @FumingZhang, |
ghost
requested review from
ghost
assigned 
|
AKS |
FumingZhang
force-pushed
the
fuming/aks-custom-headers-0623
branch
from
00c47df
to
a6bed07
Compare
FumingZhang
changed the title
--aks-custom-headers to some aks commands
FumingZhang
commented
Jun 26, 2023
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='eastus', preserve_default_location=True) | ||
| def test_aks_create_with_custom_headers(self, resource_group, resource_group_location): |
There was a problem hiding this comment.
Queued live test to validate the change.
zhoxing-ms
approved these changes
Jun 27, 2023
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=67287&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
{AKS} Add support for option
--aks-custom-headersto the following aks commands, feature request from aurora team.Fix recordings as the inherited command
az aks get-versionbumped API version yesterday (by PR #26718). Overwrite the implementation in aks-preview, so the issue won't happen again.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.