Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'aks nodepool snapshot update' command #6433

Merged
merged 22 commits into from
Jul 7, 2023

Conversation

pineapplethevoyager
Copy link
Contributor

Updates tags on a nodepool snapshot matching updated behavior!


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Updates tags on a nodepool snapshot matching updated behavior!
@azure-client-tools-bot-prd
Copy link

Hi @pineapplethevoyager,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost requested a review from zhoxing-ms June 23, 2023 16:59
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 23, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd June 23, 2023 16:59
@ghost ghost assigned zhoxing-ms Jun 23, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 23, 2023
@ghost ghost requested a review from yonzhan June 23, 2023 16:59
@ghost ghost added the AKS label Jun 23, 2023
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pineapplethevoyager
Copy link
Contributor Author

pineapplethevoyager commented Jun 30, 2023

The build fail seems common with other pipelines (Pipelines - Run 20230630.20).

@yanzhudd
Copy link
Contributor

yanzhudd commented Jul 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit d8ed3aa into Azure:main Jul 7, 2023
13 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 7, 2023

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=70238&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants