[AKS] Add --network-dataplane to az aks update command #6446

wedaly · 2023-06-27T19:14:33Z

Add the --network-dataplane flag to the az aks update command. This will allow customers to update an existing cluster to enable Azure CNI Powered by Cilium

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --network-dataplane=cilium

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2023-06-27T19:14:36Z

Hi @wedaly,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2023-06-27T19:14:39Z

Hi @wedaly,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2023-06-27T19:14:47Z

AKS

FumingZhang

LGTM, however, since the command is currently not practically available, do you really want to merge the PR?

wedaly · 2023-06-28T13:46:52Z

LGTM, however, since the command is currently not practically available, do you really want to merge the PR?

Thanks! I think it's okay to merge it ahead of the rollout, but I'm also okay waiting if that's what we usually do.

wedaly · 2023-07-24T19:59:54Z

Updated to include a live test running in eastus.

wedaly · 2023-07-24T20:00:25Z

@FumingZhang this should be ready for review now, could you please take a look? Thanks!

azure-client-tools-bot-prd · 2023-07-24T20:03:47Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks update cmd aks update added parameter network_dataplane

FumingZhang · 2023-07-25T02:36:49Z

Queued live test pipeline to validate the change, test passed.

FumingZhang

LGTM, live test validation passed but CI failed, maybe update the recording file (from pipeline artifact) may fix the issue as I couldn't check detailed error message at this moment.

wedaly · 2023-07-25T16:15:39Z

LGTM, live test validation passed but CI failed, maybe update the recording file (from pipeline artifact) may fix the issue as I couldn't check detailed error message at this moment.

rebased onto main and used test_aks_migrate_cluster_to_cilium_dataplane.yaml downloaded from the live test pipeline artifacts. Let's see if CI passes...

wedaly · 2023-07-25T16:31:10Z

hmm, still failing. The errors I'm seeing in the build output are:

E           AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_trustedaccess_rolebinding.yaml') in your current record mode ('once').
E           No match for the request (<Request (GET) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2023-03-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2023-03-01%3E)) was found.
E           Found 1 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (GET) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2022-11-01>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2022-11-01%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

E           AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_create_and_update_outbound_ips.yaml') in your current record mode ('once').
E           No match for the request (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-11-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-11-01%3E)) was found.
E           Found 1 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-05-01>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-05-01%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

I think these test cases were expecting api-version=2022-11-01 but got a newer API version instead.

These failures look unrelated to my changes? Not sure how to fix them, would appreciate any advice.

FumingZhang · 2023-07-26T02:41:45Z

hmm, still failing. The errors I'm seeing in the build output are:

E           AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_trustedaccess_rolebinding.yaml') in your current record mode ('once').
E           No match for the request (<Request (GET) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2023-03-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2023-03-01%3E)) was found.
E           Found 1 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (GET) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2022-11-01>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MC_clitest000001_cliakstest000001_westus2/providers/Microsoft.Compute/virtualMachineScaleSets?api-version=2022-11-01%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

E           AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_create_and_update_outbound_ips.yaml') in your current record mode ('once').
E           No match for the request (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-11-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-11-01%3E)) was found.
E           Found 1 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-05-01>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.Network/publicIPAddresses/cliakstest000003?api-version=2022-05-01%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

I think these test cases were expecting api-version=2022-11-01 but got a newer API version instead.

These failures look unrelated to my changes? Not sure how to fix them, would appreciate any advice.

Yeah, some recordings are broken by API version bump of some dependent commands. Fixed in PR #6557. Please rebase from main once the PR is merged.

wedaly · 2023-07-27T16:08:13Z

@zhoxing-ms this PR is ready for review, could you please take a look? Thanks!

zhoxing-ms · 2023-07-28T07:40:53Z

@FumingZhang Could you please help review this PR again?

FumingZhang · 2023-07-28T07:52:48Z

@FumingZhang Could you please help review this PR again?

The change looks good to me

wedaly · 2023-07-31T14:01:15Z

@zhoxing-ms @FumingZhang would either of you be able to merge the PR? I don't have permission to merge it. Thanks!

wedaly requested review from andyliuliming and FumingZhang as code owners June 27, 2023 19:14

azure-client-tools-bot-prd bot added this to the July 2023 (2023-08-01) milestone Jun 27, 2023

ghost requested review from zhoxing-ms and yanzhudd June 27, 2023 19:14

ghost assigned zhoxing-ms Jun 27, 2023

ghost added the Auto-Assign Auto assign by bot label Jun 27, 2023

ghost requested a review from yonzhan June 27, 2023 19:14

ghost added the AKS label Jun 27, 2023

ghost requested review from jsntcy, kairu-ms and necusjz June 27, 2023 19:14

ghost assigned necusjz Jun 27, 2023

ghost added the Network label Jun 27, 2023

yonzhan unassigned necusjz Jun 27, 2023

FumingZhang reviewed Jun 28, 2023

View reviewed changes

wedaly force-pushed the aks-update-network-dataplane branch from 92c2e02 to 4d71786 Compare July 24, 2023 19:58

FumingZhang approved these changes Jul 25, 2023

View reviewed changes

wedaly force-pushed the aks-update-network-dataplane branch from 4d71786 to 810feb5 Compare July 25, 2023 16:14

[AKS] Add --network-dataplane to az aks update command

9de5943

wedaly force-pushed the aks-update-network-dataplane branch from 810feb5 to 9de5943 Compare July 26, 2023 14:54

zhoxing-ms approved these changes Jul 28, 2023

View reviewed changes

zhoxing-ms merged commit 99a435a into Azure:main Aug 1, 2023
14 checks passed

wedaly mentioned this pull request Aug 1, 2023

[AKS] az aks update: Add --network-dataplane option Azure/azure-cli#27060

Merged

3 tasks

wedaly changed the title ~~[AKS] Add --network-dataplane to az aks update command~~ [AKS] Add --network-dataplane to az aks update command Aug 2, 2023

wedaly changed the title ~~[AKS] Add --network-dataplane to az aks update command~~ [AKS] Add --network-dataplane to az aks update command Aug 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS] Add --network-dataplane to az aks update command #6446

[AKS] Add --network-dataplane to az aks update command #6446

wedaly commented Jun 27, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Jun 27, 2023

azure-client-tools-bot-prd bot commented Jun 27, 2023

yonzhan commented Jun 27, 2023

FumingZhang left a comment

wedaly commented Jun 28, 2023

wedaly commented Jul 24, 2023

wedaly commented Jul 24, 2023

azure-client-tools-bot-prd bot commented Jul 24, 2023 •

edited

Loading

FumingZhang commented Jul 25, 2023 •

edited

Loading

FumingZhang left a comment

wedaly commented Jul 25, 2023

wedaly commented Jul 25, 2023 •

edited

Loading

FumingZhang commented Jul 26, 2023

wedaly commented Jul 27, 2023

zhoxing-ms commented Jul 28, 2023

FumingZhang commented Jul 28, 2023

wedaly commented Jul 31, 2023

[AKS] Add --network-dataplane to az aks update command #6446

[AKS] Add --network-dataplane to az aks update command #6446

Conversation

wedaly commented Jun 27, 2023 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Jun 27, 2023

azure-client-tools-bot-prd bot commented Jun 27, 2023

yonzhan commented Jun 27, 2023

FumingZhang left a comment

Choose a reason for hiding this comment

wedaly commented Jun 28, 2023

wedaly commented Jul 24, 2023

wedaly commented Jul 24, 2023

azure-client-tools-bot-prd bot commented Jul 24, 2023 • edited Loading

FumingZhang commented Jul 25, 2023 • edited Loading

FumingZhang left a comment

Choose a reason for hiding this comment

wedaly commented Jul 25, 2023

wedaly commented Jul 25, 2023 • edited Loading

FumingZhang commented Jul 26, 2023

wedaly commented Jul 27, 2023

zhoxing-ms commented Jul 28, 2023

FumingZhang commented Jul 28, 2023

wedaly commented Jul 31, 2023

wedaly commented Jun 27, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Jul 24, 2023 •

edited

Loading

FumingZhang commented Jul 25, 2023 •

edited

Loading

wedaly commented Jul 25, 2023 •

edited

Loading