-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Service Connector}: Add error code in telemetry and refactor sql connection #6450
Conversation
Hi @xfz11, |
Service Connector |
@@ -32,8 +33,13 @@ def run_cli_cmd(cmd, retry=0, interval=0, should_retry_func=None): | |||
try: | |||
return run_cli_cmd_base(cmd, retry, interval, should_retry_func) | |||
except CLIInternalError as e: | |||
error_code = 'Unknown' | |||
error_res = re.search( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this? is there existing method to mask log in cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used to get the error code of azure cli command. We use subprocess to run other CLI command. The only way to get its error code is to parse the error output.
[Release] Update index.json for extension [ serviceconnector-passwordless ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=68009&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.