{Service Connector}: Add error code in telemetry and refactor sql connection #6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xfz11, |
|
Service Connector |
yungezz
reviewed
Jun 28, 2023
| @@ -32,8 +33,13 @@ def run_cli_cmd(cmd, retry=0, interval=0, should_retry_func=None): | |||
| try: | |||
| return run_cli_cmd_base(cmd, retry, interval, should_retry_func) | |||
| except CLIInternalError as e: | |||
| error_code = 'Unknown' | |||
| error_res = re.search( | |||
There was a problem hiding this comment.
what's this? is there existing method to mask log in cli?
There was a problem hiding this comment.
It's used to get the error code of azure cli command. We use subprocess to run other CLI command. The only way to get its error code is to parse the error output.
yungezz
approved these changes
Jun 28, 2023
kairu-ms
approved these changes
Jun 29, 2023
|
[Release] Update index.json for extension [ serviceconnector-passwordless ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=68009&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.