achurchard/robustness #6473
Closed
achurchard/robustness #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VNF NFD generator
…-cli-extensions into add-cnf-generation
Jl/edit image secrets paths
Jl/refactor deploy params
removing print statement
…into add-aosm-extension
* NSD building for CNFs * linting
* Working publish * Fix the artifact upload * Working image copy * minor fix * Minor fixes * sunny merge add-aosm-extension into patryk's branch (#25) * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * comment out breaking line * minor TODOs * deleted comment * fix bring your own parameters * Markups * Fix the helm upload * Minor markups * Change error message --------- Co-authored-by: sunnycarter <[email protected]> Co-authored-by: Sunny Carter <[email protected]>
* NFDV version exposed as a CGV on an SNS * Managed identities support on NFs * Fix identiy, fix API versions * history --------- Co-authored-by: Jamie Parsons <[email protected]> Co-authored-by: Sunny Carter <[email protected]>
Fix style issues raised by `azdev style`
|
Hi @Cyclam, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aosm nfd [generate-config | build]Main changes
Use pathlib.Path rather than os file operations
strs aroundVariable renaming for clarity
Add nfd_bicep_path as abstract property on NFDGenerator
Miscellaneous style updates to keep
azdev style aosmhappyTesting
Manually running the following using an existing publisher:
az aosm nfd build --definition-type cnf --config-file cnf-input.jsoncnf-input.jsonuses the standard nginx ingress controlleraz aosm nfd build --definition-type vnf --config-file nfd-input.jsonnfd-input.jsonis for a vnet only VNF with a dummy image fileand ensuring the output matches what was generated before
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.