Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Fix verify ref docs #6507

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

wangzelin007
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Add a new parameter dep_url (dependent url).
If a extensionA is depend on another extensionB, will install extensionB first.
In this case, will install containerapp extension before verify ref docs for containerapp-preview extension.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 12, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost requested a review from yonzhan July 12, 2023 05:26
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 12, 2023
@ghost ghost assigned zhoxing-ms Jul 12, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 12, 2023

CI

@zhoxing-ms
Copy link
Contributor

I am not familiar with the logic of this CI task. Just out of curiosity, if the testing for containerapp-preview ends, will the extension containerapp need be removed?

@wangzelin007
Copy link
Member Author

wangzelin007 commented Jul 12, 2023

I am not familiar with the logic of this CI task. Just out of curiosity, if the testing for containerapp-preview ends, will the extension containerapp need be removed?

The answer is yes, will remove extensions by the folllowing code:

shutil.rmtree(temp_extension_dir)

@wangzelin007 wangzelin007 merged commit f12d922 into Azure:main Jul 12, 2023
15 checks passed
wangzelin007 added a commit to wangzelin007/azure-cli-extensions that referenced this pull request Aug 9, 2023
wangzelin007 added a commit that referenced this pull request Aug 11, 2023
* Revert "{CI} Update the --dependent-file parameter to be an optional argument to avoid introducing a breaking change. (#6521)"

This reverts commit b442cf0.

* Revert "{CI} Fix verify ref docs (#6507)"

This reverts commit f12d922.

* Revert "{CI} Fix command tree broken issue (#6573)"

This reverts commit 3df4a81.

* revert linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants