Add check-network sub-command #6579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks check-network | cmd aks check-network added |
|
Hi @alyssa1303, |
|
Hi @alyssa1303, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jsntcy,
kairu-ms and
necusjz
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=77881&view=results Last commit: Azure@824e008
…-set`: Migrate to Codegen V2 (Azure#6577) * initial gen * az tsi environment gen1 create tested * az tsi access-policy tested * location option list add -l * change to patch for reference-data-set update, fix referenceDataSetName regex pattern for create, tests passed for reference-data-set * tests passed for environment gen1 * tests passed for environment gen2 * unwrap more class into obj * dont use aaz for event-source eventhub * testsed event-source iothub which still uses sdk as well * remove all unused code, lint, rerun test, update version * move command import into function, use inheritance
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=77919&view=results Last commit: Azure@8891292
…d scenario (Azure#6535) * Fix Scenario Idx out of bound when selecting recommended scenario * Add message in `HISTORY.rst`
FumingZhang
reviewed
Aug 1, 2023
…nario mode (Azure#6541) * Fix error when enter short param in scenario mode * Fix error when enter short param in scenario mode * Update HISTORY.rst * Release New Version
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=77968&view=results Last commit: Azure@02742a8
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=79071&view=results Last commit: Azure@f2aa72a
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=79390&view=results Last commit: Azure@736b699
…azure-cli-extensions into alyssa/check-network
…azure-cli-extensions into alyssa/check-network
|
Closing due to error in rebase so have to open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.