Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Add new comment to explain the reason that pin the wheel to 0.30.0 #6842

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

wangzelin007
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 8, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2023

CI

@bebound
Copy link
Contributor

bebound commented Oct 8, 2023

azure-cli released the version pin in Azure/azure-cli#12782.
We can port this to azure-cli-extension.

@wangzelin007
Copy link
Member Author

wangzelin007 commented Oct 8, 2023

WHEEL_INFO_RE just gets package-related information through a regular expression
If we replace it with pkginfo, then all packages must be downloaded before they can be parsed, otherwise ValueError will be raised.
At the same time, the parsed content is also different from the WHEEL_INFO_RE.
The essence of this test is to check whether the package name meets expectations.
Maybe we should transplant the WHEEL_INFO_RE code directly and remove the dependence on the wheel package.
Actually I have found the code for WHEEL_INFO_RE in scripts/ci/util.py.

WHEEL_INFO_RE = re.compile(
    r"""^(?P<namever>(?P<name>.+?)(-(?P<ver>\d.+?))?)
    ((-(?P<build>\d.*?))?-(?P<pyver>.+?)-(?P<abi>.+?)-(?P<plat>.+?)
    \.whl|\.dist-info)$""",
    re.VERBOSE).match

image
image
image

@wangzelin007
Copy link
Member Author

Since wheel > 0.30.0 will not generate the metadata.json file, if we upgrade the wheel version, it may affect the installation, upgrade, and release of all extensions, so sufficient testing is required before upgrading the wheel.
image

@wangzelin007 wangzelin007 changed the title {CI} Add new comment for test_index.py to explain the reason that pin the wheel to 0.3.0 {CI} Add new comment to explain the reason that pin the wheel to 0.3.0 Oct 10, 2023
@wangzelin007 wangzelin007 changed the title {CI} Add new comment to explain the reason that pin the wheel to 0.3.0 {CI} Add new comment to explain the reason that pin the wheel to 0.30.0 Oct 10, 2023
@wangzelin007 wangzelin007 merged commit f5caab7 into Azure:main Oct 10, 2023
14 checks passed
bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Oct 16, 2023
….0 (Azure#6842)

* Update test_index.py

* Update pull_request_template.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not import Wheel.Install in test_index.py
3 participants