Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network-Manager] BREAKING CHANGE: Make some params required and remove some non-updatable params, fixes for upcoming GA #6843

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

calvinhzy
Copy link
Member

@calvinhzy calvinhzy commented Oct 8, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  1. Fix example and help info Fix Various text improvements for virtual-network-manager #6788
  2. BREAKING CHANGE: Make params required and remove non-updatable params Fix Various resource create/update parameter bugs in 'virtual-network-manager' extension. #6786
  3. Fix az network manager security-admin-config rule-collection rule update Fix Security admin rule update for 'virtual-network-manager' is dropping values. #6787

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Oct 8, 2023
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 8, 2023

❌Azure CLI Extensions Breaking Change Test
❌network-manager
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd network manager connection management-group create cmd network manager connection management-group create update parameter network_manager_id: added property required=True please remove property required=True for parameter network_manager_id of cmd network manager connection management-group create
1007 - ParaRemove network manager connection management-group update cmd network manager connection management-group update removed parameter network_manager_id please add back parameter network_manager_id for cmd network manager connection management-group update
1008 - ParaPropAdd network manager connection subscription create cmd network manager connection subscription create update parameter network_manager_id: added property required=True please remove property required=True for parameter network_manager_id of cmd network manager connection subscription create
1007 - ParaRemove network manager connection subscription update cmd network manager connection subscription update removed parameter network_manager_id please add back parameter network_manager_id for cmd network manager connection subscription update
1008 - ParaPropAdd network manager group static-member create cmd network manager group static-member create update parameter resource_id: added property required=True please remove property required=True for parameter resource_id of cmd network manager group static-member create
1008 - ParaPropAdd network manager scope-connection create cmd network manager scope-connection create update parameter resource_id: added property required=True please remove property required=True for parameter resource_id of cmd network manager scope-connection create
1008 - ParaPropAdd network manager scope-connection create cmd network manager scope-connection create update parameter tenant_id: added property required=True please remove property required=True for parameter tenant_id of cmd network manager scope-connection create
1007 - ParaRemove network manager scope-connection update cmd network manager scope-connection update removed parameter resource_id please add back parameter resource_id for cmd network manager scope-connection update
1007 - ParaRemove network manager scope-connection update cmd network manager scope-connection update removed parameter tenant_id please add back parameter tenant_id for cmd network manager scope-connection update

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2023

Network-Manager

@calvinhzy calvinhzy changed the title [Network-Manager] Fix help/examples [Network-Manager] Fix for upcoming GA Oct 9, 2023
@calvinhzy calvinhzy changed the title [Network-Manager] Fix for upcoming GA [Network-Manager] BREAKING CHANGE: Make some params requireds and remove some non-updatable params, fixes for upcoming GA Oct 10, 2023
@calvinhzy calvinhzy changed the title [Network-Manager] BREAKING CHANGE: Make some params requireds and remove some non-updatable params, fixes for upcoming GA [Network-Manager] BREAKING CHANGE: Make some params required and remove some non-updatable params, fixes for upcoming GA Oct 10, 2023
@calvinhzy calvinhzy marked this pull request as ready for review October 10, 2023 06:50
@calvinhzy calvinhzy merged commit f40fb65 into Azure:main Oct 10, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ network-manager ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=95593&view=results

bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Oct 16, 2023
…ve some non-updatable params, fixes for upcoming GA (Azure#6843)

* fix help/examples

* missed /

* missed /

* make some params required and nonupdatable

* `az network manager security-admin-config rule-collection rule create/update` since --kind is not required, update based on params provided

* test for rule update

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network
Projects
None yet
5 participants