-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{CI} Support codespace #6850
base: main
Are you sure you want to change the base?
{CI} Support codespace #6850
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @wangzelin007, |
CI |
If anyone wants to debug with vscode, here is an example configuration for
|
C901 # code flow is too complex, too many violations, to be removed in the future | ||
W503 # line break before binary operator effect on readability is subjective | ||
W504 # line break after binary operator effect on readability is subjective | ||
# line too long, it is covered by pylint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what blocks this PR from merge? we can get it merged and keep evolving, right? |
Sorry, due to security considerations, we do not plan to directly support the codespace. |
@wangzelin007 I tried contributing to this repo, but the steps to setup are many, the docs was hard to find, and in the end half of the things I needed to do still didn't work. Havig a codespace in which the code formatting, linting, compiling and running the tests just works is going to make it soooo much easier for external people like me to contribute. I'd love to understand the security considerations. I have already filed #6794 with my reasoning. |
Hi @jiasli, |
This checklist is used to make sure that common guidelines for a pull request are followed.
Please note that you need to wait 6 minutes for the first build
![image](https://private-user-images.githubusercontent.com/18628534/273753359-7cb9539a-9162-4443-9f28-c449948aac12.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5MzgxOTEsIm5iZiI6MTcyNTkzNzg5MSwicGF0aCI6Ii8xODYyODUzNC8yNzM3NTMzNTktN2NiOTUzOWEtOTE2Mi00NDQzLTlmMjgtYzQ0OTk0OGFhYzEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDAzMTEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdkNmZmMGM0MWVlZDVlODYzYWYzNzdiMTgwYjgyZDQ3OWI0MDVmNzhlZWViZWVhYzc0ZWQ3MTk2YTBlNTBmNmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YxPlhBJ0CojsKdD_raPPkJBZW0piv9F7eLqryc548Hw)
screenshot:
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.