feat(retina): add disable network observability command for update #6894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snguyen64
requested review from
andyliuliming,
FumingZhang and
kairu-ms
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter disable_network_observability |
|
Hi @snguyen64, |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
snguyen64
force-pushed
the
retina/network_observability_update_disable
branch
from
b0e96f1
to
9cec601
Compare
snguyen64
force-pushed
the
retina/network_observability_update_disable
branch
from
9cec601
to
6b647a0
Compare
FumingZhang
approved these changes
Oct 26, 2023
|
Please fix conflicting files |
zhoxing-ms
reviewed
Nov 7, 2023
3 tasks
|
please fix CI failed items |
|
Fixed the failed test and resolved conflict in PR #6951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add disable network observability command for update cluster and adds tests.
This was also mentioned in this issue: #6740
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks cluster update --disable-network-observability
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.