Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{application-insights} Add connection string into app settings #6986

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

AllyW
Copy link
Member

@AllyW AllyW commented Nov 13, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

closed Azure/azure-cli#28348

Copy link

azure-client-tools-bot-prd bot commented Nov 13, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @AllyW,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @AllyW,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 13, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@AllyW AllyW force-pushed the component-to-web-connection-string branch from 80be93b to 6374f4c Compare March 18, 2024 08:03
Copy link

⚠️ Suggestions

Module: application-insights

  • Update version to 1.2.1 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@AllyW AllyW changed the title add connection string into app settings {application-insights} Add connection string into app settings Mar 18, 2024
@yonzhan yonzhan requested a review from jsntcy March 18, 2024 11:14
@AllyW AllyW merged commit e5845d4 into Azure:main Mar 25, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ application-insights ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=143412&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'az monitor app-insights component' is only using deprecated IKey.
5 participants