Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[az vm repair] version 1.0.0b1 #7113

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Conversation

haagha
Copy link
Member

@haagha haagha commented Dec 22, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair run

Bug fix for invoking az vm repair run on windows

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Dec 22, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@haagha haagha changed the title [az vm repair[ version 0.5.10 [az vm repair] version 0.5.10 Dec 22, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 22, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@haagha
Copy link
Member Author

haagha commented Dec 22, 2023

azdev style check passes locally

@@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "0.5.9"
VERSION = "0.5.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use version 1.0.0b1 as preview version instead since we should never use 0.x.x as versioning now. See more details in https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md

src/vm-repair/setup.py Outdated Show resolved Hide resolved
src/vm-repair/HISTORY.rst Outdated Show resolved Hide resolved
@jsntcy
Copy link
Member

jsntcy commented Dec 27, 2023

@haagha,

  1. Please fix the style errors (errors in test code)
    image

  2. Please rerun the affected tests lively to avoid regression.

@haagha haagha requested a review from jsntcy January 4, 2024 14:41
@haagha
Copy link
Member Author

haagha commented Jan 4, 2024

@jsntcy The azdev style check is failing but not sure what the error is.

@haagha haagha changed the title [az vm repair] version 0.5.10 [az vm repair] version 1.0.0b1 Jan 4, 2024
@yanzhudd yanzhudd merged commit 2daf9df into Azure:main Jan 5, 2024
14 of 15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jan 5, 2024

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=119526&view=results

ddouglas-msft pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants