Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4568, allow user to set tunnel bind address #7195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fengxx
Copy link

@fengxx fengxx commented Jan 18, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 18, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️bastion
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network bastion tunnel cmd network bastion tunnel added parameter bind_host

Copy link

Hi @fengxx,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 18, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 18, 2024
Copy link
Contributor

Thank you for your contribution fengxx! We will review the pull request and get back to you soon.

@fengxx
Copy link
Author

fengxx commented Jan 18, 2024

@microsoft-github-policy-service agree

@fengxx
Copy link
Author

fengxx commented Jan 18, 2024

style checks were not caused by the PR

src\bastion\azext_bastion\custom.py:159:0: C0301: Line too long (130/120) (line-too-long)
src\bastion\azext_bastion\custom.py:265:0: C0301: Line too long (146/120) (line-too-long)
src\bastion\azext_bastion\custom.py:269:0: C0301: Line too long (130/120) (line-too-long)
src\bastion\azext_bastion\custom.py:378:0: C0301: Line too long (130/120) (line-too-long)
src\bastion\azext_bastion\custom.py:387:0: C0301: Line too long (154/120) (line-too-long)
src\bastion\azext_bastion\custom.py:396:0: C0301: Line too long (126/120) (line-too-long)
src\bastion\azext_bastion\custom.py:401:0: C0301: Line too long (125/120) (line-too-long)
src\bastion\azext_bastion\custom.py:231:0: R0914: Too many local variables (28/25) (too-many-locals)
src\bastion\azext_bastion\custom.py:258:8: W0107: Unnecessary pass statement (unnecessary-pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants