Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fix for 'approuting update' command #7197

Merged
merged 26 commits into from
Jan 30, 2024

Conversation

bosesuneha
Copy link
Member

@bosesuneha bosesuneha commented Jan 18, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Fix issue #27940.

Related command

az aks approuting update -g -n --enable-kv --attach-kv ${KEYVAULTID}

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 18, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bosesuneha,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 18, 2024

AKS

@bosesuneha bosesuneha marked this pull request as draft January 18, 2024 18:39
@bosesuneha bosesuneha marked this pull request as ready for review January 19, 2024 07:40
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a live test case about updating app routing configs (using custom key vault) on a cluster with monitoring addon enabled.

@bosesuneha bosesuneha marked this pull request as draft January 26, 2024 08:55
@bosesuneha bosesuneha marked this pull request as ready for review January 26, 2024 22:16
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FumingZhang
Copy link
Member

FumingZhang commented Jan 29, 2024

Queued live test to validate the change, test passed!

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanzhudd yanzhudd merged commit b5a0a3f into Azure:main Jan 30, 2024
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=125945&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants