Fixed issue when registry creds are provided for ACRs using `containerapp up` command #7198

harryli0108 · 2024-01-18T23:56:15Z

Description

This PR aims to fix an issue with current container app up command in the scenario where user provides --registry-server, --registry-password, and --registry-username for ACRs. In the past, up command will treat it as ACRs in the current subscription and apply them. However, this results in issues when user starts to use ACRs cross subscriptions.

Before

After

Related command

az containerapp up

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-01-18T23:56:18Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

azure-client-tools-bot-prd · 2024-01-18T23:56:21Z

Hi @harryli0108,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-01-18T23:56:26Z

Thank you for your contribution! We will review the pull request and get back to you soon.

daniv-msft · 2024-01-19T00:01:07Z

The change looks good to me overall. However, could you please clarify: was this a regression? If yes, do you know when/how it was introduced?

daniv-msft · 2024-01-19T00:04:05Z

Another question: could you please clarify if this fix should be in the extension (this repo), or in the base Azure CLI?
https://github.com/Azure/azure-cli/blob/main/src/azure-cli/azure/cli/command_modules/containerapp/_up_utils.py

At this point some of our changes are checked in in the Extensions repo (mostly for preview features), while all the base features are in the base Azure CLI repo so that customers can get these features without installing an extra extension.

Greedygre · 2024-01-31T02:33:41Z

Hi @harryli0108

The following test is failed because of the api-version of containerapp has been update from 2023-08-01-preview to 2023-11-02-preview, please rerun the test or checkout this file to main as you have rerun it before. Thanks.

FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_up_on_connected_env.py::ContainerAppUpConnectedEnvImageTest::test_containerapp_up_on_arc_e2e

 No match for the request (<Request (GET) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.App/containerApps?api-version=2023-11-02-preview>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.App/containerApps?api-version=2023-11-02-preview%3E)) was found.
E           Found 9 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (GET) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.App/containerApps?api-version=2023-08-01-preview>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.App/containerApps?api-version=2023-08-01-preview%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

Greedygre · 2024-01-31T06:55:38Z

Hi @harryli0108

Please merge the latest code from main branch.

FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_customized_keys_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_customized_keys_yaml_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_none_client_type
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_up_on_connected_env.py::ContainerAppUpConnectedEnvImageTest::test_containerapp_up_on_arc_e2e

Greedygre · 2024-02-01T05:08:53Z

These tests failed:

FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_customized_keys_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_customized_keys_yaml_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py::ContainerappServiceBindingTests::test_containerapp_dev_service_binding_none_client_type
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_up_on_connected_env.py::ContainerAppUpConnectedEnvImageTest::test_containerapp_up_on_arc_e2e
============ 5 failed, 107 passed, 36 skipped in 496.07s (0:08:16) ============

I will handle the others but do not include test_containerapp_up_on_arc_e2e.

test_containerapp_dev_service failed because command az containerapp service is deprecated.

Fixed: #7236

Greedygre · 2024-02-21T01:20:40Z

src/containerapp/HISTORY.rst

@@ -11,7 +11,8 @@ upcoming
 0.3.47
 ++++++
 * 'az containerapp add-on' : support for add-on milvus create and delete commands
-* [Breaking Change] 'az containerapp service': deprecate command from Azure CLI version 2.59.0
+* 'az containerapp up' : Fix registry not found error in subscription when registry server parameters are provided for ACR from another subscription


0.3.47 has been released, please move this description to upcoming.

Greedygre · 2024-02-21T01:23:51Z

Where is test test_containerapp_up_artifact_with_bullseye_buildpack_e2e?

gitguardian · 2024-02-27T19:19:52Z

⚠️ GitGuardian has uncovered 139 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_bookworm_buildpack_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_bookworm_buildpack_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_java_component.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_java_component.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_add_on_binding_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_on_arc_auto_install_extension_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_dapr_component_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_dapr_component_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_managed_service_binding_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_managed_service_binding_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_multiple_environments_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_multiple_environments_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_without_arguments_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_on_arc_auto_install_extension_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_dapr_component_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_java_component.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Basic Auth String	`1dd747e`	src/spring/azext_spring/tests/latest/recordings/test_app_deploy_container.yaml	View secret
-	Basic Auth String	`1dd747e`	src/spring/azext_spring/tests/latest/recordings/test_app_deploy_container_command.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Basic Auth String	`1dd747e`	src/spring/azext_spring/tests/latest/recordings/test_app_deploy_container.yaml	View secret
-	Basic Auth String	`1dd747e`	src/spring/azext_spring/tests/latest/recordings/test_app_deploy_container_command.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1d8b8e7`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_bookworm_buildpack_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_service_binding_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_service_binding_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`0c4f9d6`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret

and 59 others.

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

Greedygre · 2024-02-29T04:42:18Z

Hi @wangzelin007

Can you help to merge this PR? Thanks.

Moazzem-Hossain-pixel

Help to resolve

MoazzemHossain-bot

Need support

harryli0108 added 2 commits January 18, 2024 15:16

Fixed issue when registry creds are provided for ACRs in capp up

8efb0f9

Lint error fixed

7cad26a

azure-client-tools-bot-prd bot added this to the January 2024 (2024-02-06) milestone Jan 18, 2024

microsoft-github-policy-service bot requested review from yonzhan, wangzelin007, yanzhudd, zhoxing-ms, jsntcy, ruslany, sanchitmehta, ebencarek, JennyLawrance, howang-ms, vinisoto, chinadragon0515, vturecek, torosent, pagariyaalok, Juliehzl, jijohn14 and Greedygre January 18, 2024 23:56

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 18, 2024

microsoft-github-policy-service bot assigned zhoxing-ms Jan 18, 2024

microsoft-github-policy-service bot added the ContainerApp label Jan 18, 2024

daniv-msft approved these changes Jan 19, 2024

View reviewed changes

Added missing tests

b7dde54

harryli0108 added 2 commits January 31, 2024 10:11

Merge branch 'main' into harrli/cross-sub-registry-fail-fix

b062baf

Rerun live tests

cb94f12

harryli0108 added 8 commits February 1, 2024 10:25

Merge branch 'main' into harrli/cross-sub-registry-fail-fix

cd9f035

Re-recorded tests

cbada5e

Merge branch 'main' into harrli/cross-sub-registry-fail-fix

6071218

Updated test recording

6162cf2

Updated failed test

e8743b4

Revert unmodified test

02dc57d

Fixed pylint errors

0c8a7bb

Merge branch 'main' into harrli/cross-sub-registry-fail-fix

6a35dd4

Greedygre reviewed Feb 21, 2024

View reviewed changes

Updated HISTORY

67717d0

harryli0108 and others added 4 commits February 27, 2024 11:22

Fixed indent

c37d9fd

Merge branch 'main' into harrli/cross-sub-registry-fail-fix

50bf63b

Updated test recordings

51cbb88

merge main

0c4f9d6

Greedygre approved these changes Feb 29, 2024

View reviewed changes

zhoxing-ms assigned yanzhudd Feb 29, 2024

zhoxing-ms approved these changes Feb 29, 2024

View reviewed changes

wangzelin007 approved these changes Feb 29, 2024

View reviewed changes

wangzelin007 merged commit 372a3f3 into Azure:main Feb 29, 2024
11 of 15 checks passed

Moazzem-Hossain-pixel reviewed May 2, 2024

View reviewed changes

MoazzemHossain-bot reviewed May 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed issue when registry creds are provided for ACRs using `containerapp up` command #7198

Fixed issue when registry creds are provided for ACRs using `containerapp up` command #7198

harryli0108 commented Jan 18, 2024

azure-client-tools-bot-prd bot commented Jan 18, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jan 18, 2024

yonzhan commented Jan 18, 2024

daniv-msft commented Jan 19, 2024

daniv-msft commented Jan 19, 2024

Greedygre commented Jan 31, 2024 •

edited

Loading

Greedygre commented Jan 31, 2024

Greedygre commented Feb 1, 2024 •

edited

Loading

Greedygre Feb 21, 2024

Greedygre commented Feb 21, 2024

gitguardian bot commented Feb 27, 2024 •

edited

Loading

Greedygre commented Feb 29, 2024

Moazzem-Hossain-pixel left a comment

MoazzemHossain-bot left a comment

Fixed issue when registry creds are provided for ACRs using containerapp up command #7198

Fixed issue when registry creds are provided for ACRs using containerapp up command #7198

Conversation

harryli0108 commented Jan 18, 2024

Description

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Jan 18, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Jan 18, 2024

yonzhan commented Jan 18, 2024

daniv-msft commented Jan 19, 2024

daniv-msft commented Jan 19, 2024

Greedygre commented Jan 31, 2024 • edited Loading

Greedygre commented Jan 31, 2024

Greedygre commented Feb 1, 2024 • edited Loading

Greedygre Feb 21, 2024

Choose a reason for hiding this comment

Greedygre commented Feb 21, 2024

gitguardian bot commented Feb 27, 2024 • edited Loading

⚠️ GitGuardian has uncovered 139 secrets following the scan of your pull request.

Greedygre commented Feb 29, 2024

Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

Fixed issue when registry creds are provided for ACRs using `containerapp up` command #7198

Fixed issue when registry creds are provided for ACRs using `containerapp up` command #7198

azure-client-tools-bot-prd bot commented Jan 18, 2024 •

edited

Loading

Greedygre commented Jan 31, 2024 •

edited

Loading

Greedygre commented Feb 1, 2024 •

edited

Loading

gitguardian bot commented Feb 27, 2024 •

edited

Loading