Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link HCRP (Arc for servers) machine to vCenter #7203

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Jan 22, 2024


Link HCRP machine to vCenter.
The location, custom-location properties can be figured out from the vCenter and inventory-item can be figured out by searching for the BiosId in the Machine properties (called VMUUID) from the vCenter/inventoryItems. So, making all three properties as optional.

Have added some examples in the help section for this experience.

Related command

az connectedvmware

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 22, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️connectedvmware
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd connectedvmware vm create cmd connectedvmware vm create added parameter machine_id
⚠️ 1009 - ParaPropRemove connectedvmware vm create cmd connectedvmware vm create update parameter custom_location: removed property required=True
⚠️ 1009 - ParaPropRemove connectedvmware vm create cmd connectedvmware vm create update parameter resource_group_name: removed property required=True
⚠️ 1009 - ParaPropRemove connectedvmware vm create cmd connectedvmware vm create update parameter resource_name: removed property required=True

Copy link

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@nascarsayan nascarsayan marked this pull request as ready for review January 22, 2024 06:09
@subbartt
Copy link

@jsntcy , can you help merge the changes, seems kairu is OOF. We have validated the changes and all the tests are passing. Signed off from my side.

@nascarsayan nascarsayan changed the title Link HCRP machine to vCenter Link HCRP machine (Arc for server machine) to vCenter Jan 22, 2024
@nascarsayan nascarsayan changed the title Link HCRP machine (Arc for server machine) to vCenter Link HCRP (Arc for servers) machine to vCenter Jan 22, 2024
@wangzelin007
Copy link
Member

Can you add tests for these new parameters?
If the tests are too complex, please make sure you have tested them locally.
Others look good to me.

@nascarsayan
Copy link
Contributor Author

Can you add tests for these new parameters? If the tests are too complex, please make sure you have tested them locally. Others look good to me.

@wangzelin007 , Adding automated tests would be difficult, because every time we run using --live, we need to revert the original VM (uninstall arc for servers), or setup a new machine. I have tested it locally, and it is working.

@wangzelin007 wangzelin007 merged commit dab6605 into Azure:main Jan 24, 2024
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=124507&view=results

@nascarsayan nascarsayan deleted the link-to-vcenter branch January 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants