-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link HCRP (Arc for servers) machine to vCenter #7203
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
connectedvmware vm create | cmd connectedvmware vm create added parameter machine_id |
||
connectedvmware vm create | cmd connectedvmware vm create update parameter custom_location : removed property required=True |
||
connectedvmware vm create | cmd connectedvmware vm create update parameter resource_group_name : removed property required=True |
||
connectedvmware vm create | cmd connectedvmware vm create update parameter resource_name : removed property required=True |
Hi @nascarsayan, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
@jsntcy , can you help merge the changes, seems kairu is OOF. We have validated the changes and all the tests are passing. Signed off from my side. |
Can you add tests for these new parameters? |
Co-authored-by: ZelinWang <[email protected]>
Co-authored-by: ZelinWang <[email protected]>
@wangzelin007 , Adding automated tests would be difficult, because every time we run using |
[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=124507&view=results |
Link HCRP machine to vCenter.
The
location
,custom-location
properties can be figured out from the vCenter andinventory-item
can be figured out by searching for the BiosId in theMachine
properties (calledVMUUID
) from thevCenter/inventoryItems
. So, making all three properties as optional.Have added some examples in the help section for this experience.
Related command
az connectedvmware
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.