-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s-extension] Update extension CLI to v1.6.0 #7204
[k8s-extension] Update extension CLI to v1.6.0 #7204
Conversation
* First draft for Data Protection K8s backup extension (Pending internal review) * Removing tracing * Minor changes to improve azdev style * Internal PR review feedback Co-authored-by: Rishabh Raj <[email protected]>
…ad of workspace (#175) * fix: Update DCR creation to Clusters resource group instead of workspace * . * . * casing check
adding the api version to the operation definition in the client factory
bump k8s-extension version to 1.3.6
…n expected by the service
…tests adding tests for all 4 extension types calls
…into release-1.3.6
…tensiontypetests adding upstream test for extension types
…into release-1.3.6
…into release-1.3.6
…eate (#188) * Add more validations and user prompt for existing installation scenario Signed-off-by: Shubham Sharma <[email protected]> * Add Dapr test' Signed-off-by: Shubham Sharma <[email protected]> * Handle stateful set Signed-off-by: Shubham Sharma <[email protected]> * Update default handling Signed-off-by: Shubham Sharma <[email protected]> * Fix HA handling Signed-off-by: Shubham Sharma <[email protected]> * Add placement service todo Signed-off-by: Shubham Sharma <[email protected]> * Add non-interactive mode Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Update tests Signed-off-by: Shubham Sharma <[email protected]> * Reset configuration for StatefulSet during k8s upgrade Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Retrigger tests Signed-off-by: Shubham Sharma <[email protected]> * Add changes to manage ha and placement params Signed-off-by: Shubham Sharma <[email protected]> * Update message Signed-off-by: Shubham Sharma <[email protected]> * nits Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]>
use the recomended param for flag
* Add WorkloadIAM extension support and tests * Review fixes - Reorder imports. - User-provided configuration settings must ignore the case. However, this is only true for settings recognized by the code. Any other setting is assumed to be a Helm chart value path that needs to be left alone. * Fix flake8 issues
bump k8s-extension version to 1.5.3
…ion dependency for ARC (#264)
The old code was unreliable. The new code should work in a similar way but it should be able to handle errors in a more graceful way.
microsoft.workloadiam: Refactor subcommand invocation
bump k8s-extension version to v1.5.4
️✔️Azure CLI Extensions Breaking Change Test
|
k8s-extension |
* AAD related changes in dataprotection aks ext CLI | ||
* microsoft.azuremonitor.containers: Make containerlogv2 as default as true and remove region dependency for ARC | ||
* microsoft.workloadiam: Refactor subcommand invocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests for these PR changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have our own custom tests(CI checks) in our forked repo that create a kubernetes cluster and perform create, update, list, show and delete actions for each of the partner extensions.
[Release] Update index.json for extension [ k8s-extension ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=124535&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.