AKS: Add changes for resource consumption for Azure Container Storage #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukhoakash
requested review from
andyliuliming and
FumingZhang
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create update parameter storage_pool_option: updated property choices from ['NVMe', 'SSD'] to ['NVMe', 'Temp'] |
||
| aks update | cmd aks update update parameter disable_azure_container_storage: added property choices=['all', 'azureDisk', 'elasticSan', 'ephemeralDisk'] |
||
| aks update | cmd aks update update parameter storage_pool_option: updated property choices from ['NVMe', 'SSD'] to ['NVMe', 'Temp', 'all'] |
|
Hi @mukhoakash, |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Could you please fix the failed CI checks? |
andyliuliming
requested changes
Feb 20, 2024
mukhoakash
force-pushed
the
acstor_static_res
branch
from
3f9b89f
to
c6a6c25
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
from
c6a6c25
to
5e2c1a7
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
from
b42e036
to
4419127
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
from
4419127
to
ee57fff
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
4 times, most recently
from
aa51ec8
to
420dfcd
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
from
420dfcd
to
2556842
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
from
bad7c40
to
061ebb5
Compare
mukhoakash
force-pushed
the
acstor_static_res
branch
from
061ebb5
to
6f442da
Compare
|
@FumingZhang All CI runs fixed. Live test with both the cases started:
|
FumingZhang
approved these changes
Mar 15, 2024
| @@ -12,6 +12,11 @@ To release a new version, please select a new version number (usually plus 1 to | |||
| Pending | |||
| +++++++ | |||
|
|
|||
| 2.0.0b5 | |||
There was a problem hiding this comment.
Please update VERSION in setup.py so the change could be released.
yanzhudd
approved these changes
Mar 15, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
andyliuliming
approved these changes
Mar 15, 2024
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=139662&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iner Storage
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.