Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases 0.27.0 #7223

Closed
wants to merge 1 commit into from
Closed

Releases 0.27.0 #7223

wants to merge 1 commit into from

Conversation

v-soujanya
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 29, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @v-soujanya,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @v-soujanya,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 29, 2024
@v-soujanya
Copy link
Contributor Author

Hi Team, we tried multiple attempts but verify extension index check is continuously failing, we need your assistance here. From our end we have published the latest version with 0.27.0 & we are able to download the whl file.
Release link:
https://github.com/Azure/azure-devops-cli-extension/releases
Whl file link:
https://github.com/Azure/azure-devops-cli-extension/releases/download/20240129.4/azure_devops-0.27.0-py2.py3-none-any.whl
Below is the error we are seeing in the pipeline url
https://dev.azure.com/azclitools/public/_build/results?buildId=125766&view=logs&j=b121d099-c3c0-52ad-95f1-31c1567c9ad4&t=ca40adef-e63f-5fd5-f30e-e39a0bf0e914
image
Error:

Traceback (most recent call last):
File "/mnt/vss/_work/1/s/./scripts/ci/test_index.py", line 208, in test_metadata
self.assertDictEqual(metadata, item['metadata'],
AssertionError: {'aze[835 chars]3.0)', 'distro==1.3.0']}], 'summary': 'Tools f[43 chars]7.0'} != {'aze[835 chars]3.0)']}], 'summary': 'Tools for managing Azure[26 chars]7.0'}
Diff is 1423 characters long. Set self.maxDiff to None to see it. : Metadata for azure_devops-0.27.0-py2.py3-none-any.whl in index doesn't match the expected of:

@v-soujanya
Copy link
Contributor Author

@jsntcy could you please help on this??

@@ -17044,9 +17044,9 @@
}
],
"summary": "Tools for managing Azure DevOps.",
"version": "0.26.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why you update the entry for 0.26.0, usually we need add a new item for 0.27.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsntcy This was the new release version we published on devops extension. Below is the last PR we made changes as same to release new version.
#5803

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsntcy any update on this??

Copy link
Member

@jsntcy jsntcy Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not overwrite metadata of 0.26.0 for new version 0.27.0, because if you did like that, cx cannot install 0.26.0 any longer once you release 0.27.0. You should add a new entry for 0.27.0 like all other extensions did, an example: 5ce810e.

You can see that many previous versions are not available for cx now because you overwrite the metadata of previous versions before, that's not the correct behavior for cx.
image

Copy link
Member

@jsntcy jsntcy Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW,
Now we support new versioning for extension and 0.x.x is not recommended any longer. The version will start from 1.0.0 (stable) or 1.0.0b1 (preview). You can find more details in https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md.
Please use the correct version next time: 1.0.0 (stable) or 1.0.0b1 (preview).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @jsntcy, our new version is 0.27.0 as per the new version guidelines we are making it as 1.27.0. Please confirm is it okay?? post your confirmation I will create a new entry with the new version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsntcy Any suggestions on above ask by Soujanya from your end? We need to do some more changes with the new rule conventions so taking suggestions here first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @jsntcy, our new version is 0.27.0 as per the new version guidelines we are making it as 1.27.0. Please confirm is it okay?? post your confirmation I will create a new entry with the new version.

If it's stable version, we recommend you use version 1.0.0 as it's first version from1.x.x.

@v-soujanya v-soujanya closed this by deleting the head repository Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants