-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Support reset default value for loadbalancer profile and natgateway profile #7230
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# -------------------------------------------------------------------------------------------- | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. See License.txt in the project root for license information. | ||
# -------------------------------------------------------------------------------------------- | ||
|
||
from types import SimpleNamespace | ||
|
||
|
||
def create_nat_gateway_profile(managed_outbound_ip_count, idle_timeout, models: SimpleNamespace): | ||
"""parse and build NAT gateway profile""" | ||
if not is_nat_gateway_profile_provided(managed_outbound_ip_count, idle_timeout): | ||
return None | ||
|
||
profile = models.ManagedClusterNATGatewayProfile() | ||
return configure_nat_gateway_profile(managed_outbound_ip_count, idle_timeout, profile, models) | ||
|
||
|
||
def update_nat_gateway_profile(managed_outbound_ip_count, idle_timeout, profile, models: SimpleNamespace): | ||
"""parse and update an existing NAT gateway profile""" | ||
if not is_nat_gateway_profile_provided(managed_outbound_ip_count, idle_timeout): | ||
return profile | ||
if not profile: | ||
profile = models.ManagedClusterNATGatewayProfile() | ||
return configure_nat_gateway_profile(managed_outbound_ip_count, idle_timeout, profile, models) | ||
|
||
|
||
def is_nat_gateway_profile_provided(managed_outbound_ip_count, idle_timeout): | ||
return any([managed_outbound_ip_count is not None, idle_timeout]) | ||
|
||
|
||
def configure_nat_gateway_profile(managed_outbound_ip_count, idle_timeout, profile, models: SimpleNamespace): | ||
"""configure a NAT Gateway with customer supplied values""" | ||
if managed_outbound_ip_count is not None: | ||
ManagedClusterManagedOutboundIPProfile = models.ManagedClusterManagedOutboundIPProfile | ||
profile.managed_outbound_ip_profile = ManagedClusterManagedOutboundIPProfile( | ||
count=managed_outbound_ip_count | ||
) | ||
|
||
if idle_timeout: | ||
profile.idle_timeout_in_minutes = idle_timeout | ||
|
||
return profile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this part can be omitted as it's part of the create process, even if setting it to 0 is ignored, the default value will be backfilled to 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value is 1