Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor azure service mesh update function for better readability #7231

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Refactor azure service mesh update function for better readability #7231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3d9ec2
Refactor azure service mesh update function for better readability
deveshdama Jan 30, 2024
4631735
fix az style issues
deveshdama Jan 30, 2024
99b3409
fix style issues
deveshdama Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++
* Deprecate the alias "-r" of parameter --source-resource-id in `az aks trustedaccess rolebinding create`
* Refactor azure service mesh related code to meet cli style requirements.

1.0.0b4
+++++++
Expand Down
6 changes: 5 additions & 1 deletion src/aks-preview/azext_aks_preview/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,11 @@ def load_command_table(self, _):
) as g:
g.custom_command("enable", "aks_mesh_enable", supports_no_wait=True)
g.custom_command(
"disable", "aks_mesh_disable", supports_no_wait=True, confirmation=True
"disable",
"aks_mesh_disable",
supports_no_wait=True,
confirmation="Existing Azure Service Mesh Profile values will be reset.\n"
+ "Are you sure you want to perform this operation?"
)
g.custom_command(
"enable-ingress-gateway",
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,7 +2986,7 @@ def _aks_mesh_update(
)

try:
mc = aks_update_decorator.update_mc_profile_default()
mc = aks_update_decorator.fetch_mc()
mc = aks_update_decorator.update_azure_service_mesh_profile(mc)
except DecoratorEarlyExitException:
return None
Expand Down
Loading